Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SecuritySolution] Security Solution Dashboard edit mode #159486
[SecuritySolution] Security Solution Dashboard edit mode #159486
Changes from 93 commits
92bae1c
b3f7f76
13b9323
c3a1e5c
49b90f1
359158d
02353fc
debeedd
0c15e35
4a1ea0a
28b1ff0
875b411
8beb62e
2444f9a
6ffcd0c
3769910
92ffcf4
854196f
91f0f0a
b61e354
27ce42e
af6c770
6b7bac5
73359e2
99ee686
d888c16
95310b6
f5d671c
e68b150
363cbc3
59a727d
315de70
a4d75d8
7947e20
a6311ef
d52c958
64289cc
9e0a48b
ff3b6c9
a99c548
2513569
670a129
89bee44
e3c90d0
a6ec841
5f3fdde
7bd943e
77f3f3e
d7a57aa
e51a31d
cad4508
64baad8
6889ed3
b50cc51
2176061
b223193
72a222f
814d44e
f75afdb
af66475
b53836d
5b0d8ac
431aef1
166aa08
bfe13da
c2394c2
4142d0b
39bc769
f3ad2df
1fb58e5
ea44fc5
4dda0c6
b71ca7d
c380c3b
61c8b57
33d31dd
b710595
88eb719
51218f5
7e9f488
417bc2f
1be6482
2fa6ebb
68ce921
fb81162
cff552b
1ff57f4
fc62f31
81991a1
b09ca64
cad9a11
9786e0c
61d31d3
c9d61f0
0008540
86bc355
f5afe7c
82aa6f4
b1a6085
2d10a03
57d1743
17b5171
f4e579c
54e9958
e79290a
8de11cd
89b5987
e901852
dfd70c0
de3cbdb
5dd3ce1
3a6cb1d
2d461d8
eebbd69
f8d9cfc
9032024
3402568
f4af650
61a2f32
6b06b87
8c660ca
a779e84
9660eed
78b2587
82b7438
4ca438d
05ec497
237a1aa
738b4e9
528600a
3b863c1
017927c
5fb8252
5ae45d6
a368344
2da03b1
3348b38
2c8113e
e9cc346
0083b75
61bf111
6716411
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Why track this in the dashboard container and get it from the
dashboard_editing_toolbar.tsx
rather than just getting access to it directly where it's needed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, removed currentAppId here and get it from DashboardEditingToolbar's prop,
originatingApp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found that dashboard's empty's screen still need this information, so added
originatingApp
togetCreationOptions.getEmbeddableContainerContext
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice call exporting the top nav + its lazy wrapper like this 🔥