[SecuritySolution] Security Solution Dashboard edit mode

[angorayc]

Summary

issue: #152955

Test environment: https://p.elstc.co/paste/9-b8FqRA#EkVP6KV1UAFOu1cWFwX1laj63P9wc5eQtnT7bCPyEuX

Known issues: #159486 (comment)

Screen.Recording.2023-09-26.at.15.53.50.mov

1. Reuse Kibana Dashboard's tool bar

2. Dashboard with a Managed tag does not have the edit tool bar under the title.

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios

[angorayc]

Known issues:
1. It doesn't return to Security Dashboard after Createing visualization from Dashboard:

create_vis_from_dashboard.mov

2. Not sure how to verify Share > Embedded Code and what's the right behaviour

share_embedd_dashboard.mov

[angorayc]

Issue created: #167694

During the review, we also found that by default there are two Security Solution tags got created. This causes dashboard listing not filtering properly and might cause users confusion.

1. Created when [Elastic Security] Detection rule monitoring dashboard was installed
   x-pack/plugins/security_solution/server/lib/detection_engine/rule_monitoring/logic/detection_engine_health/assets/tag_security_solution.json
   

2. Created when landing on dashboard listing page: x-pack/plugins/security_solution/public/dashboards/containers/use_fetch_security_tags.ts
   

[stratoula]

Visualizations team changes LGTM! Thanx @ThomThomson 🙇

[semd]

LGTM!
Thanks for addressing the comments Angela, this is awesome! 🚀

[semd]

@elasticmachine merge upstream

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 6716411
• Cloud Deployment

Failed CI Steps

• Investigations - Security Solution Cypress Tests #2
• Defend Workflows Cypress Tests #4

Test Failures

• [job] [logs] Defend Workflows Cypress Tests #4 / Artifact pages Trusted applications should update Endpoint Policy on Endpoint when adding Trusted application name should update Endpoint Policy on Endpoint when adding Trusted application name
• [job] [logs] Investigations - Security Solution Cypress Tests #2 / Discover Timeline State Integration saved search should rename the saved search on timeline rename should rename the saved search on timeline rename

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
dashboard	385	387	+2
securitySolution	4604	4620	+16
total			+18

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
dashboard	102	106	+4
embeddable	445	446	+1
total			+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
canvas	1011.8KB	1011.8KB	+30.0B
dashboard	371.2KB	374.3KB	+3.1KB
embeddable	12.0KB	11.9KB	-83.0B
lens	1.4MB	1.4MB	+51.0B
securitySolution	13.0MB	13.0MB	+4.3KB
total			+7.4KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
dashboard	10	11	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
dashboard	35.0KB	35.6KB	+572.0B
embeddable	78.0KB	78.1KB	+95.0B
securitySolution	62.7KB	62.8KB	+42.0B
total			+709.0B

Unknown metric groups

API count

id	before	after	diff
dashboard	105	109	+4
embeddable	545	547	+2
total			+6

async chunk count

id	before	after	diff
dashboard	10	11	+1

ESLint disabled line counts

id	before	after	diff
dashboard	8	9	+1

References to deprecated APIs

id	before	after	diff
securitySolution	661	659	-2

Total ESLint disabled count

id	before	after	diff
dashboard	8	9	+1

History

• 💔 Build #164416 failed 61bf111
• 💔 Build #164357 failed 2c8113e
• 💛 Build #164260 was flaky 2da03b1
• 💚 Build #164197 succeeded a368344
• 💔 Build #164177 failed 5ae45d6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @angorayc