[ML] Integrates into serverless kibana #159433

jgowdyelastic · 2023-06-10T13:18:51Z

Adds function to ML plugin server side setup contract (setFeaturesEnabled) to enable/disable features. Features being, anomaly detection, data frame analytics or natural language processing.
- Each serverless plugin (search, observability and security) now calls setFeaturesEnabled to enable different features on setup.
Adds three new feature capabilities, isADEnabled, isDFAEnabled, isNLPEnabled
- Updates the capabilities switcher to toggle these capabilities based on the shared feature API. This currently has a bug where the switcher isn't triggered for API tag checking.
deeplinks are now only registered based on the feature capabilities, these control what is shown in the nav menu for search and observability projects.
Adds the Machine Learning nav menu section to the serverless_search plugin, to match the serverless_observability plugin.
Does not updated the serverless_security plugin's nav menu. (update, serverless_observability nav menu also now does not contain ML)

Relates to #160891

…fix'

…bility

jgowdyelastic · 2023-06-26T10:51:02Z

x-pack/plugins/serverless_search/kibana.jsonc

      "console",
-      "searchprofiler",
+      "dashboard",


adding ml but also sorting the list alphabetically

jgowdyelastic · 2023-06-26T12:49:08Z

x-pack/plugins/serverless_security/kibana.jsonc

@@ -13,10 +13,11 @@
      "security"
    ],
    "requiredPlugins": [
-      "serverless",
+      "kibanaReact",


adding ml but also sorting the list alphabetically

jgowdyelastic · 2023-06-28T10:09:44Z

@kpatticha That's odd. It works ok for me. This is the nav menu I see.

How are you running kibana?
I'm using yarn serverless-oblt

I suspect ML just isn't enabled at all in the es that you are running.

kpatticha · 2023-06-28T10:59:01Z

I suspect ML just isn't enabled at all in the es that you are running

hmm, that could be. Are you running --trial ?

fixes: #159681 fixes: #153777 <img width="1470" alt="image" src="https://github.com/elastic/kibana/assets/3369346/eb810c65-c780-4597-9570-4b30cf2e1b09"> ### Related ML deep links won't show until it's merged #159433 ### Test - e2e will be covered #160674

qn895 · 2023-06-28T17:30:39Z

On non-serverless mode, the navigation is now like this. Is this intentional?

jgowdyelastic · 2023-06-29T08:46:10Z

On non-serverless mode, the navigation is now like this. Is this intentional?

No, not intentional, this has been fixed here

jgowdyelastic · 2023-06-29T09:36:15Z

@kpatticha Apologies, it looks like you were right, the ML menu had very recently been removed from the observability menu in this PR
I had merged this PR with main via github, but not updated my local copy, hence me still seeing it in the menu.

I have updated this PR to put the ML menu back in. Once this PR is in, I believe the menus will be the responsibility of the each serverless plugin team, so the ML links can be moved about wherever needed. I've just added an ML section in this PR as an initial step.

kpatticha · 2023-06-29T10:50:52Z

x-pack/plugins/serverless_observability/public/components/side_navigation/index.tsx

@@ -94,6 +94,10 @@ const navigationTree: NavigationTreeDefinition = {
        },
      ],
    },
+    {
+      type: 'navGroup',


In the recent mockups, we won't use the ml presets for the observability side nav but instead a custom node tree. It would be great if you revert this change.

I've removed this ML section 3a7eae1

It's worth pointing out for other reviews that until these custom ML links mentioned above are added, there will be no way to access ML pages from the side navigation menu when running the serverless Observability project.
It will still be possible to access ML pages from kibana's app search feature at the top of kibana.

kpatticha

oblt LGTM. I just left a small comment regarding the preset.

sebelga

LGTM 👍

kibana-ci · 2023-06-30T16:30:13Z

💚 Build Succeeded

Buildkite Build
Commit: 3cab0e9

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`ml`	1762	1761	-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`ml`	3.4MB	3.4MB	+1014.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`ml`	33	32	-1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`ml`	73.0KB	73.8KB	+856.0B
`serverlessObservability`	21.8KB	21.7KB	-71.0B
`serverlessSearch`	25.7KB	25.7KB	-42.0B
total			+743.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	14	16	+2
`securitySolution`	413	417	+4
`serverlessObservability`	4	5	+1
total			+7

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	15	17	+2
`securitySolution`	492	496	+4
`serverlessObservability`	4	5	+1
total			+7

History

💚 Build #139358 succeeded ec63b24
💚 Build #139194 succeeded 61a2370
💔 Build #139143 failed 82a51a7
💚 Build #139079 succeeded 3a7eae1
💚 Build #139044 succeeded 3a53e15
💚 Build #138758 succeeded a1b822d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

qn895 · 2023-06-30T20:49:28Z

Tested latest changes and LGTM 🎉

Update once again the side navigation tree to match the latest mocks - https://www.figma.com/file/S4fn8L4j8fG1H6331Lw3kb/IA%2FNavigation?type=design&node-id=1265-151762&mode=design ### Before ![image](https://github.com/elastic/kibana/assets/3369346/65e1a394-e3ad-43da-a193-c2b2861bbbb1) ### After https://github.com/elastic/kibana/assets/3369346/ba570fba-798e-4273-95e7-e0e5a1ec9a88 ### Notes for reviewers - ML deep links will be visible after the #159433 --------- Co-authored-by: Kibana Machine <[email protected]>

jgowdyelastic and others added 23 commits June 10, 2023 14:13

[ML] Integrating into serverless kibana

9a8ccdc

removing temp debugging code

c11e161

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

ae9b242

…fix'

adding type keyword

186450e

Merge remote-tracking branch 'origin/main' into ml-serverless-compati…

becbc5b

…bility

Merge remote-tracking branch 'origin/main' into ml-serverless-compati…

3c40d28

…bility

updating navigation menus for es and observability

a1661d4

updating capabilities switcher

5ad8f61

correcting icon

8b70ee0

Merge remote-tracking branch 'origin/main' into ml-serverless-compati…

05bf8bb

…bility

Merge remote-tracking branch 'origin/main' into ml-serverless-compati…

68bc89d

…bility

registering deeplinks based on features

9509dba

fixing types

ccca708

disabling notifications

1bd3ffb

fixing types

8dfae15

Merge branch 'main' into ml-serverless-compatibility

770910a

Merge branch 'main' into ml-serverless-compatibility

9871236

Merge branch 'main' into ml-serverless-compatibility

abf97f1

Merge branch 'main' into ml-serverless-compatibility

2b7467f

fixing mocked nav

f1e7ff8

fixing capabilities tests

98385e3

Merge branch 'main' into ml-serverless-compatibility

7c2c77c

Merge remote-tracking branch 'origin/main' into ml-serverless-compati…

fbcf0f3

…bility

gbamparop mentioned this pull request Jun 23, 2023

[Observability] Serverless navigation #153777

Closed

jgowdyelastic added 3 commits June 26, 2023 09:43

Merge branch 'main' into ml-serverless-compatibility

3e18119

filtering notifications based on type

fb48d6d

adding missing import

7976b22

jgowdyelastic commented Jun 26, 2023

View reviewed changes

jgowdyelastic requested a review from darnautov June 26, 2023 12:54

jgowdyelastic added 2 commits June 29, 2023 09:44

Merge branch 'main' into ml-serverless-compatibility

826b9d2

fixing links when not in serverless

c29461a

adding ml back into oblt menu

3a53e15

kpatticha reviewed Jun 29, 2023

View reviewed changes

kpatticha approved these changes Jun 29, 2023

View reviewed changes

jgowdyelastic added 3 commits June 29, 2023 12:52

removing ml section from oblt

3a7eae1

adjusting overview page

82a51a7

fixing canViewMlNodes value for viewer users

61a2370

kpatticha mentioned this pull request Jun 30, 2023

[Serverless] Update observability side navigation #160866

Merged

sebelga approved these changes Jun 30, 2023

View reviewed changes

Merge branch 'main' into ml-serverless-compatibility

ec63b24

semd approved these changes Jun 30, 2023

View reviewed changes

Merge branch 'main' into ml-serverless-compatibility

3cab0e9

qn895 approved these changes Jun 30, 2023

View reviewed changes

jgowdyelastic merged commit 055a104 into elastic:main Jul 1, 2023

kibanamachine added the backport:skip This commit does not require backporting label Jul 1, 2023

jgowdyelastic deleted the ml-serverless-compatibility branch July 1, 2023 07:08

jgowdyelastic mentioned this pull request Jul 1, 2023

[Kibana Core] Allow configuration to specify an array of "disabled routes" for server AND UI #157266

Closed

peteharverson added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:enhancement labels Aug 22, 2023

peteharverson changed the title ~~[ML] Integrating into serverless kibana~~ [ML] Integrates into serverless kibana Aug 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Integrates into serverless kibana #159433

[ML] Integrates into serverless kibana #159433

jgowdyelastic commented Jun 10, 2023 •

edited

Loading

jgowdyelastic Jun 26, 2023

jgowdyelastic Jun 26, 2023

jgowdyelastic commented Jun 28, 2023 •

edited

Loading

kpatticha commented Jun 28, 2023

qn895 commented Jun 28, 2023

jgowdyelastic commented Jun 29, 2023

jgowdyelastic commented Jun 29, 2023 •

edited

Loading

kpatticha Jun 29, 2023

jgowdyelastic Jun 29, 2023 •

edited

Loading

kpatticha left a comment

sebelga left a comment

kibana-ci commented Jun 30, 2023

ESLint disabled line counts

Total ESLint disabled count

qn895 commented Jun 30, 2023

[ML] Integrates into serverless kibana #159433

[ML] Integrates into serverless kibana #159433

Conversation

jgowdyelastic commented Jun 10, 2023 • edited Loading

jgowdyelastic Jun 26, 2023

Choose a reason for hiding this comment

jgowdyelastic Jun 26, 2023

Choose a reason for hiding this comment

jgowdyelastic commented Jun 28, 2023 • edited Loading

kpatticha commented Jun 28, 2023

qn895 commented Jun 28, 2023

jgowdyelastic commented Jun 29, 2023

jgowdyelastic commented Jun 29, 2023 • edited Loading

kpatticha Jun 29, 2023

Choose a reason for hiding this comment

jgowdyelastic Jun 29, 2023 • edited Loading

Choose a reason for hiding this comment

kpatticha left a comment

Choose a reason for hiding this comment

sebelga left a comment

Choose a reason for hiding this comment

kibana-ci commented Jun 30, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Public APIs missing exports

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

qn895 commented Jun 30, 2023

jgowdyelastic commented Jun 10, 2023 •

edited

Loading

jgowdyelastic commented Jun 28, 2023 •

edited

Loading

jgowdyelastic commented Jun 29, 2023 •

edited

Loading

jgowdyelastic Jun 29, 2023 •

edited

Loading