Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] Set navLinkStatus for deeplinks #159681

Closed
kpatticha opened this issue Jun 14, 2023 · 5 comments · Fixed by #160620
Closed

[Observability] Set navLinkStatus for deeplinks #159681

kpatticha opened this issue Jun 14, 2023 · 5 comments · Fixed by #160620
Assignees
Labels
apm:serverless Team:APM All issues that need APM UI Team support

Comments

@kpatticha
Copy link
Contributor

kpatticha commented Jun 14, 2023

caused by #159125

Deeplinks that don't specify navLinkStatus property are hidden by default
We need to set the navLinkStatus to show them in serverless

apm:


infra/logs:

@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 14, 2023
@kpatticha kpatticha added apm:serverless and removed needs-team Issues missing a team label labels Jun 14, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 14, 2023
@kpatticha kpatticha added the Team:APM All issues that need APM UI Team support label Jun 14, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 14, 2023
@kpatticha kpatticha self-assigned this Jun 15, 2023
@kpatticha
Copy link
Contributor Author

@sebelga

Setting the navLinkStatus to make side nav work in serverless will lead to modifications in the side navigation of classic kibana since both environments share the same deep links but use different side navigation setup.

Before: classic kibana
Screenshot 2023-06-15 at 14 10 34

In classic kibana these links should be hidden from the side nav

After: classic kibana

Screenshot 2023-06-15 at 14 10 18

Unless I miss something here, it seems we need to handle this differently. wdyt?

@kpatticha
Copy link
Contributor Author

Another alternative I could think of is to set navLinkStatus conditionally according to the environment

@sebelga
Copy link
Contributor

sebelga commented Jun 19, 2023

Another alternative I could think of is to set navLinkStatus conditionally according to the environment

That seems like the cleanest approach. Add dependency on the serverless plugin and then set the visibility of the link accordingly.

@sebelga
Copy link
Contributor

sebelga commented Jun 19, 2023

Another approach would be:

  • By default they are not visible (to fix classic)
  • Add a config flag in serverless.yml available in the UI
  • In your pugin.ts start you read the config and if it is true you change the visibility of the links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:serverless Team:APM All issues that need APM UI Team support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants