[Security Solution] Adds support for custom Security Assistant SystemPrompts and Conversations #159365

spong · 2023-06-09T06:47:54Z

Summary

Adds the following new abilities to the Security Assistant:

Adds ability to create/delete custom SystemPrompts
- Configurable Name, Prompt, Default Conversations, and Default for New Conversations
- Introduces System Prompt setting within Conversation Settings
Adds ability to create/delete custom Conversations
- Create conversation in-line within the Conversation selector by just typing the new conversation name and pressing enter
- Applies configured SystemPrompt and default connector on conversation creation
Extracts baseSystemPrompts so they can be provided to the AssistantContextProvider on a per solution basis. The consolidates assistant dependency defaults to the x-pack/plugins/security_solution/public/assistant/content and x-pack/packages/kbn-elastic-assistant/impl/content directories respectively.
- All Security SystemPrompts now organized in BASE_SECURITY_SYSTEM_PROMPTS
- All Security Conversations organized in BASE_SECURITY_CONVERSATIONS

See epic https://github.com/elastic/security-team/issues/6775 (internal) for additional details.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

…ant-system-prompt-crud

kibana-ci · 2023-06-13T08:28:38Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 4b3dc95

Failed CI Steps

Security Solution Tests #6

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	4104	4113	+9

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/elastic-assistant`	55	63	+8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	10.8MB	10.8MB	-55.1KB

Unknown metric groups

API count

id	before	after	diff
`@kbn/elastic-assistant`	75	83	+8

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`securitySolution`	410	414	+4
total			+6

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`securitySolution`	491	495	+4
total			+6

History

💔 Build #133902 failed d864651

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @spong

spong · 2023-06-13T16:24:30Z

x-pack/packages/kbn-elastic-assistant/impl/assistant/conversation_selector/index.tsx

+        setTimeout(() => {
+          deleteConversation(cId);
+        }, 0);
+        // onSystemPromptDeleted(cId);


Plz delete 🙂

spong · 2023-06-13T16:24:41Z

x-pack/packages/kbn-elastic-assistant/impl/assistant/conversation_selector/index.tsx

+      (newOptions: ConversationSelectorOption[]) => {
+        if (newOptions.length === 0) {
+          setSelectedOptions([]);
+          // handleSelectionChange([]);


Plz delete 🙂

spong · 2023-06-13T16:24:51Z

x-pack/packages/kbn-elastic-assistant/impl/assistant/conversation_selector/index.tsx

+        } else if (conversationOptions.findIndex((o) => o.label === newOptions?.[0].label) !== -1) {
+          setSelectedConversationId(newOptions?.[0].label);
+        }
+        // setSelectedConversationId(value ?? DEFAULT_CONVERSATION_TITLE);


Plz delete 🙂

spong · 2023-06-13T16:30:14Z

...tic-assistant/impl/assistant/conversation_settings_popover/conversation_settings_popover.tsx

+            />
+          </EuiFormRow>
+
+          {provider === OpenAiProviderType.OpenAi && <></>}


Remove or add back specific conversation/api settings

andrew-goldstein · 2023-06-13T16:54:20Z

...-elastic-assistant/impl/assistant/prompt_editor/system_prompt/select_system_prompt/index.tsx

+          </EuiFlexItem>
+          <EuiFlexItem grow={false}>
+            {/* Right offset to compensate for 'selected' icon of EuiSuperSelect since native footers aren't supported*/}
+            <div style={{ width: '24px' }} />


nit: consider creating a const for the style

spong · 2023-06-13T17:43:18Z

...tic-assistant/impl/assistant/prompt_editor/system_prompt/system_prompt_modal/translations.ts

+export const ADD_SYSTEM_PROMPT = i18n.translate(
+  'xpack.elasticAssistant.assistant.promptEditor.systemPrompt.systemPromptModal.addSystemPromptTitle',
+  {
+    defaultMessage: 'Add system prompt...',


Could be caps since proper noun/feature

spong · 2023-06-13T17:44:03Z

...ck/packages/kbn-elastic-assistant/impl/assistant/prompt_editor/system_prompt/translations.ts

+export const ADD_NEW_SYSTEM_PROMPT = i18n.translate(
+  'xpack.elasticAssistant.assistant.firstPromptEditor.addNewSystemPrompt',
+  {
+    defaultMessage: 'Add new system prompt...',


Could be caps b/c proper noun/feature

spong · 2023-06-13T17:53:26Z

x-pack/packages/kbn-elastic-assistant/impl/assistant_context/index.tsx

+      allQuickPrompts: localStorageQuickPrompts ?? [],
+      allSystemPrompts: localStorageSystemPrompts ?? [],


Verify referential integrity WRT re-renders

elasticmachine · 2023-06-13T18:03:28Z

Pinging @elastic/security-solution (Team: SecuritySolution)

andrew-goldstein

Thanks for these features @spong! 🙏
Also thanks for paring on the review & desk testing
LGTM 🚀

spong added 2 commits June 9, 2023 00:31

Adds CRUD for SystemPrompts and Conversations

d36e29f

Merge branch 'main' of github.com:elastic/kibana into security-assist…

d864651

…ant-system-prompt-crud

spong self-assigned this Jun 9, 2023

spong added 3 commits June 12, 2023 14:01

Merge branch 'main' of github.com:elastic/kibana into security-assist…

c3a1a4b

…ant-system-prompt-crud

Fixes bugs, styling issues, and updates tests

ed8f2e3

Merge branch 'main' of github.com:elastic/kibana into security-assist…

4b3dc95

…ant-system-prompt-crud

spong added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. release_note:feature Makes this part of the condensed release notes v8.9.0 Feature:Security Assistant Security Assistant needs_docs labels Jun 13, 2023

spong commented Jun 13, 2023

View reviewed changes

andrew-goldstein reviewed Jun 13, 2023

View reviewed changes

spong commented Jun 13, 2023

View reviewed changes

spong marked this pull request as ready for review June 13, 2023 18:03

spong requested review from a team as code owners June 13, 2023 18:03

andrew-goldstein approved these changes Jun 13, 2023

View reviewed changes

spong merged commit 6b65e90 into elastic:main Jun 13, 2023

kibanamachine added the backport:skip This commit does not require backporting label Jun 13, 2023

spong deleted the security-assistant-system-prompt-crud branch June 13, 2023 18:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] Adds support for custom Security Assistant SystemPrompts and Conversations #159365

[Security Solution] Adds support for custom Security Assistant SystemPrompts and Conversations #159365

spong commented Jun 9, 2023 •

edited

Loading

kibana-ci commented Jun 13, 2023

API count

ESLint disabled line counts

Total ESLint disabled count

spong Jun 13, 2023

spong Jun 13, 2023

spong Jun 13, 2023

spong Jun 13, 2023

andrew-goldstein Jun 13, 2023

spong Jun 13, 2023

spong Jun 13, 2023

spong Jun 13, 2023

elasticmachine commented Jun 13, 2023

andrew-goldstein left a comment

		allQuickPrompts: localStorageQuickPrompts ?? [],
		allSystemPrompts: localStorageSystemPrompts ?? [],

[Security Solution] Adds support for custom Security Assistant SystemPrompts and Conversations #159365

[Security Solution] Adds support for custom Security Assistant SystemPrompts and Conversations #159365

Conversation

spong commented Jun 9, 2023 • edited Loading

Summary

Checklist

kibana-ci commented Jun 13, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

API count

ESLint disabled line counts

Total ESLint disabled count

History

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Jun 13, 2023

andrew-goldstein left a comment

Choose a reason for hiding this comment

spong commented Jun 9, 2023 •

edited

Loading