-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add feature flags to apm config and serverless.oblt.yml #159136
Changes from 10 commits
35422ce
f40dd45
cc554c2
3c8b968
97c1182
eca126c
33ad69e
42fb17a
fd927d2
85c56fe
2091bf7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -181,6 +181,13 @@ export default function ({ getService }: PluginFunctionalProviderContext) { | |
'xpack.apm.managedServiceUrl (any)', | ||
'xpack.apm.serverlessOnboarding (any)', | ||
'xpack.apm.latestAgentVersionsUrl (string)', | ||
'xpack.apm.featureFlags.agentConfigurationAvailable (any)', | ||
'xpack.apm.featureFlags.configurableIndicesAvailable (any)', | ||
'xpack.apm.featureFlags.infrastructureTabAvailable (any)', | ||
'xpack.apm.featureFlags.infraUiAvailable (any)', | ||
'xpack.apm.featureFlags.migrationToFleetAvailable (any)', | ||
'xpack.apm.featureFlags.sourcemapApiAvailable (any)', | ||
'xpack.apm.featureFlags.storageExplorerAvailable (any)', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think these should be booleans There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hi @thomheymann, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's strange. Maybe the renderer doesn't infer the type correctly because of the context conditional: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes if we use a conditional rendering, the renderer is currently unable to infer the type based on provided default value. Hence it will always result in |
||
'xpack.cases.files.allowedMimeTypes (array)', | ||
'xpack.cases.files.maxSize (number)', | ||
'xpack.cases.markdownPlugins.lens (boolean)', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: we could also use the YAML tree format to avoid repetition 😇