add feature flags to apm config and serverless.oblt.yml #159136

MiriamAparicio · 2023-06-06T15:41:53Z

Closes #159040

Add configuration values to hide UI components and block api in serverless.oblt.yml

Examples

Non Serverless

Serverless

apmmachine · 2023-06-06T15:42:09Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

…eature-flags

elasticmachine · 2023-06-12T09:35:24Z

Pinging @elastic/apm-ui (Team:APM)

x-pack/plugins/apm/public/components/routing/templates/settings_template.stories.tsx

x-pack/plugins/apm/server/index.ts

achyutjhunjhunwala · 2023-06-12T09:58:05Z

x-pack/plugins/apm/server/index.ts

+      schema.boolean({
+        defaultValue: false,
+      }),
+      schema.oneOf([schema.literal(true)], { defaultValue: true })


I didn't understand the notEqual logic here.

Basically, if we are not running in serverless context, its being enforced to a true literal check and the default value could be true?

Yes, it's like and if/else

Yes, i understand the schema.conditional.
What i don't get it is, when we are not running in serverless mode, you always want this settings to be true ? This is what i don't get it.

This config means

If we are running in serverless mode, then default value is false, but it would give *.yml file the preference. Which mean in serverless.oblt.yml file, it needs to be set as true only then it will be enabled.

If we are not running in serverless mode, it will always be true.

is this the expected behaviour ?

Reason for asking this is, since you are setting it as true in non serverless mode, you will have to update the security teams tests also where they check for exposed settings.

This might also need documentation update for these exposed settings. The moment you update the security tests, someone from the security team will provide more details

If we are not running in serverless mode, it will always be true.

is this the expected behaviour ?

Yes, we want these values to be true when we are not in serverless

This might also need documentation update for these exposed settings. The moment you update the security tests, someone from the security team will provide more details

As you said I needed to update the security test and the team was ping to review these changes, I'm waiting for them for more details

config/serverless.oblt.yml

…eature-flags

x-pack/plugins/apm/server/index.ts

thomheymann · 2023-06-14T09:11:14Z

test/plugin_functional/test_suites/core_plugins/rendering.ts

+        'xpack.apm.featureFlags.infraUiAvailable (any)',
+        'xpack.apm.featureFlags.migrationToFleetAvailable (any)',
+        'xpack.apm.featureFlags.sourcemapApiAvailable (any)',
+        'xpack.apm.featureFlags.storageExplorerAvailable (any)',


I think these should be booleans

hi @thomheymann,
I set them initially to boolean in this commit bf0a260, but the test were failing

That's strange. Maybe the renderer doesn't infer the type correctly because of the context conditional:
https://github.com/elastic/kibana/pull/159136/files#diff-fa8fe01d402a7eb5cbc387759a4ea3930f3cc056d90477c04232d3ab91afaac7R17-R25
Let's leave as is for now in that case.

Yes if we use a conditional rendering, the renderer is currently unable to infer the type based on provided default value. Hence it will always result in any type

thomheymann

LGTM!

sorenlouv

lgtm

achyutjhunjhunwala

LGTM 👍🏼 Good work with the flags

afharo

config/serverless.oblt.yml changes LGTM

afharo · 2023-06-19T08:44:23Z

config/serverless.oblt.yml

+## Disable APM UI components and API calls
+xpack.apm.featureFlags.agentConfigurationAvailable: false
+xpack.apm.featureFlags.configurableIndicesAvailable: false
+xpack.apm.featureFlags.infrastructureTabAvailable: false
+xpack.apm.featureFlags.infraUiAvailable: false
+xpack.apm.featureFlags.migrationToFleetAvailable: false
+xpack.apm.featureFlags.sourcemapApiAvailable: false
+xpack.apm.featureFlags.storageExplorerAvailable: false


NIT: we could also use the YAML tree format to avoid repetition 😇

Suggested change

## Disable APM UI components and API calls

xpack.apm.featureFlags.agentConfigurationAvailable: false

xpack.apm.featureFlags.configurableIndicesAvailable: false

xpack.apm.featureFlags.infrastructureTabAvailable: false

xpack.apm.featureFlags.infraUiAvailable: false

xpack.apm.featureFlags.migrationToFleetAvailable: false

xpack.apm.featureFlags.sourcemapApiAvailable: false

xpack.apm.featureFlags.storageExplorerAvailable: false

## Disable APM UI components and API calls

xpack.apm.featureFlags:

agentConfigurationAvailable: false

configurableIndicesAvailable: false

infrastructureTabAvailable: false

infraUiAvailable: false

migrationToFleetAvailable: false

sourcemapApiAvailable: false

storageExplorerAvailable: false

kibana-ci · 2023-06-19T09:51:44Z

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`apm`	46	47	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.6MB	3.6MB	-333.0B

Unknown metric groups

API count

id	before	after	diff
`apm`	46	47	+1

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	13	15	+2
`securitySolution`	411	415	+4
total			+6

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	14	16	+2
`securitySolution`	494	498	+4
total			+6

History

💚 Build #135271 succeeded 1ef4e1cb9a1401a4b051a8a5d4074668901610f6
💛 Build #135122 was flaky 4361a50cabbe879255c1d2ce6340d5ca19d4c4b8
💚 Build #134834 succeeded 33ad69e
💚 Build #134635 succeeded e9919db66c887164ca15fe6ee35b449f1d5225a5
💛 Build #134468 was flaky 3c8b968
💔 Build #134433 failed bf0a260f6e803ef214b872e39d389fddd9e019b8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

MiriamAparicio added 2 commits June 12, 2023 09:58

add feature flags to apm config and serverless.oblt.yml

35422ce

Merge remote-tracking branch 'upstream/main' into 159040-add-config-f…

f40dd45

…eature-flags

MiriamAparicio force-pushed the 159040-add-config-feature-flags branch from e83afd8 to f40dd45 Compare June 12, 2023 09:00

MiriamAparicio added Team:APM All issues that need APM UI Team support release_note:feature Makes this part of the condensed release notes apm:serverless v8.9.0 labels Jun 12, 2023

MiriamAparicio marked this pull request as ready for review June 12, 2023 09:35

MiriamAparicio requested a review from a team as a code owner June 12, 2023 09:35

achyutjhunjhunwala reviewed Jun 12, 2023

View reviewed changes

x-pack/plugins/apm/public/components/routing/templates/settings_template.stories.tsx Outdated Show resolved Hide resolved

achyutjhunjhunwala reviewed Jun 12, 2023

View reviewed changes

x-pack/plugins/apm/server/index.ts Show resolved Hide resolved

fix incorrent feature flag value

cc554c2

achyutjhunjhunwala reviewed Jun 12, 2023

View reviewed changes

MiriamAparicio force-pushed the 159040-add-config-feature-flags branch from 748888b to bf0a260 Compare June 12, 2023 15:14

MiriamAparicio requested a review from a team as a code owner June 12, 2023 15:14

fix plugin functional tests

3c8b968

MiriamAparicio force-pushed the 159040-add-config-feature-flags branch from bf0a260 to 3c8b968 Compare June 12, 2023 16:22

sorenlouv reviewed Jun 12, 2023

View reviewed changes

config/serverless.oblt.yml Outdated Show resolved Hide resolved

sorenlouv reviewed Jun 12, 2023

View reviewed changes

config/serverless.oblt.yml Outdated Show resolved Hide resolved

MiriamAparicio added 2 commits June 13, 2023 09:16

Merge remote-tracking branch 'upstream/main' into 159040-add-config-f…

97c1182

…eature-flags

remove schemaAvailable flag

eca126c

MiriamAparicio force-pushed the 159040-add-config-feature-flags branch from e7a0959 to eca126c Compare June 13, 2023 13:58

remove spacesAvailable flag

33ad69e

afharo reviewed Jun 13, 2023

View reviewed changes

x-pack/plugins/apm/server/index.ts Outdated Show resolved Hide resolved

jasonrhodes mentioned this pull request Jun 13, 2023

[Kibana Core] Allow configuration to specify an array of "disabled routes" for server AND UI #157266

Closed

thomheymann reviewed Jun 14, 2023

View reviewed changes

improve readability in config for feature flags

42fb17a

thomheymann approved these changes Jun 14, 2023

View reviewed changes

fix merge conflicts

fd927d2

MiriamAparicio force-pushed the 159040-add-config-feature-flags branch from 1ef4e1c to fd927d2 Compare June 19, 2023 07:35

MiriamAparicio requested a review from a team as a code owner June 19, 2023 07:35

Merge branch 'main' into 159040-add-config-feature-flags

85c56fe

sorenlouv approved these changes Jun 19, 2023

View reviewed changes

achyutjhunjhunwala approved these changes Jun 19, 2023

View reviewed changes

afharo approved these changes Jun 19, 2023

View reviewed changes

Merge branch 'main' into 159040-add-config-feature-flags

2091bf7

MiriamAparicio merged commit 56ac338 into elastic:main Jun 19, 2023

MiriamAparicio deleted the 159040-add-config-feature-flags branch June 19, 2023 10:18

kibanamachine added the backport:skip This commit does not require backporting label Jun 19, 2023

MiriamAparicio mentioned this pull request Jun 29, 2023

[APM] Add config for serverless feature flags api tests #160869

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add feature flags to apm config and serverless.oblt.yml #159136

add feature flags to apm config and serverless.oblt.yml #159136

MiriamAparicio commented Jun 6, 2023 •

edited

Loading

apmmachine commented Jun 6, 2023

elasticmachine commented Jun 12, 2023

achyutjhunjhunwala Jun 12, 2023 •

edited

Loading

MiriamAparicio Jun 12, 2023

achyutjhunjhunwala Jun 12, 2023 •

edited

Loading

achyutjhunjhunwala Jun 12, 2023 •

edited

Loading

MiriamAparicio Jun 13, 2023

thomheymann Jun 14, 2023

MiriamAparicio Jun 14, 2023 •

edited

Loading

thomheymann Jun 14, 2023

achyutjhunjhunwala Jun 19, 2023

thomheymann left a comment

sorenlouv left a comment

achyutjhunjhunwala left a comment

afharo left a comment

afharo Jun 19, 2023 •

edited

Loading

kibana-ci commented Jun 19, 2023

API count

ESLint disabled line counts

Total ESLint disabled count

add feature flags to apm config and serverless.oblt.yml #159136

add feature flags to apm config and serverless.oblt.yml #159136

Conversation

MiriamAparicio commented Jun 6, 2023 • edited Loading

apmmachine commented Jun 6, 2023

🤖 GitHub comments

elasticmachine commented Jun 12, 2023

achyutjhunjhunwala Jun 12, 2023 • edited Loading

Choose a reason for hiding this comment

MiriamAparicio Jun 12, 2023

Choose a reason for hiding this comment

achyutjhunjhunwala Jun 12, 2023 • edited Loading

Choose a reason for hiding this comment

achyutjhunjhunwala Jun 12, 2023 • edited Loading

Choose a reason for hiding this comment

MiriamAparicio Jun 13, 2023

Choose a reason for hiding this comment

thomheymann Jun 14, 2023

Choose a reason for hiding this comment

MiriamAparicio Jun 14, 2023 • edited Loading

Choose a reason for hiding this comment

thomheymann Jun 14, 2023

Choose a reason for hiding this comment

achyutjhunjhunwala Jun 19, 2023

Choose a reason for hiding this comment

thomheymann left a comment

Choose a reason for hiding this comment

sorenlouv left a comment

Choose a reason for hiding this comment

achyutjhunjhunwala left a comment

Choose a reason for hiding this comment

afharo left a comment

Choose a reason for hiding this comment

afharo Jun 19, 2023 • edited Loading

Choose a reason for hiding this comment

kibana-ci commented Jun 19, 2023

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

API count

ESLint disabled line counts

Total ESLint disabled count

History

MiriamAparicio commented Jun 6, 2023 •

edited

Loading

achyutjhunjhunwala Jun 12, 2023 •

edited

Loading

achyutjhunjhunwala Jun 12, 2023 •

edited

Loading

achyutjhunjhunwala Jun 12, 2023 •

edited

Loading

MiriamAparicio Jun 14, 2023 •

edited

Loading

afharo Jun 19, 2023 •

edited

Loading