Fix preview chart in APM Latency threshold rule

[benakansara]

Resolves the following for APM Latency threshold rule:

• [APM] Alert previews only breakdown by environment #152218
• Preview chart should show data as per selected group-by fields #155489

Improvements in the preview chart:

• Showing data grouped by selected group by fields
• Showing 5 groups from each bucket
• Showing last x units (minutes, hours, etc.) data
• Added loading indicator
• Showing tooltip
• Always showing legend
• Max Y is slightly higher than maximum of highest y value or threshold
• Adjusting chart to always show the threshold line
• Fixed
  • When removing some fields like transaction type, transaction name, chart showed no data
  • Hiding a particular group (by clicking on legend item), readjusted max Y value, but same was not reset to original when enabling the group back

Before

Screen.Recording.2023-05-30.at.09.59.48.mov

After

Screen.Recording.2023-05-30.at.10.14.19.mov

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[elasticmachine]

Pinging @elastic/actionable-observability (Team: Actionable Observability)

[elasticmachine]

Pinging @elastic/apm-ui (Team:APM)

[sorenlouv]

/oblt-deploy

[sorenlouv]

Showing 3 groups from each bucket

From the video it looks like we are showing 10 groups (there are 10 legends). Am I missing something?

EDIT: Ahh, is it because the groups are not constant between the buckets? Would be great if for the preview we could select 3 groups, and show only those 3 for every bucket.

[benakansara]

From the video it looks like we are showing 10 groups (there are 10 legends). Am I missing something?

EDIT: Ahh, is it because the groups are not constant between the buckets? Would be great if for the preview we could select 3 groups, and show only those 3 for every bucket.

yes, the groups are not constant. I will check if we can keep the selected groups constant.

[benakansara]

/oblt-deploy

[fkanout]

Tested locally, and it works as expected. However, I left some comments

[fkanout]

I saw that this file/getIntervalInSeconds function is used in other rules too but with no unit test, I assume it's just working 😄

[benakansara]

Added tests 71f62fd

[sorenlouv]

My bad; two PRs are fixing the APM preview chart!

Now worries. And perhaps this is a good indication that the empty state can be improved :)

[benakansara]

@sqren We hid the preview charts in APM rules in 8.8.0. I think @fkanout was checking the PR where chart was completely hidden, not in empty state.
For empty state, the chart will show "No data to display".

[fkanout]

I tested it, and it works as expected, in the Alert details page and in the rule flyout. Great job, @benakansara!

[sorenlouv]

I think @fkanout was checking the PR where chart was completely hidden, not in empty state. For empty state, the chart will show "No data to display".

Ahh, perfect!!

[sorenlouv]

all comments made. lgtm 👍

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: a2243dd

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
apm	3.6MB	3.6MB	+420.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
apm	113	112	-1

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	13	15	+2
securitySolution	411	415	+4
total			+6

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	14	16	+2
securitySolution	494	498	+4
total			+6

History

• 💚 Build #136083 succeeded dc4d955
• 💚 Build #136058 succeeded 94b6252
• 💚 Build #136026 succeeded d85c95d
• 💛 Build #135885 was flaky 5b0cbb5
• 💔 Build #135878 failed 6a34526
• 💚 Build #135491 succeeded 8aa3b9a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @benakansara