Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview chart should show data as per selected group-by fields #155489

Closed
benakansara opened this issue Apr 21, 2023 · 2 comments
Closed

Preview chart should show data as per selected group-by fields #155489

benakansara opened this issue Apr 21, 2023 · 2 comments
Assignees
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0

Comments

@benakansara
Copy link
Contributor

benakansara commented Apr 21, 2023

After transaction.name is added in the group-by dropdown, the preview chart should show data as per selected group-by fields including transaction.name in the following rules:

  • APM Latency threshold
  • APM Failed transaction rate
  • APM Error count threshold

Dependencies

@benakansara benakansara added the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Apr 21, 2023
@benakansara benakansara self-assigned this Apr 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

benakansara added a commit that referenced this issue Jun 19, 2023
Resolves the following for APM Failed transaction rate and APM Error
count rules:
- #152218
- #155489

Improvements in the preview chart:
- Showing data grouped by selected group by fields
- Showing 5 groups from each bucket
- Showing last x units (minutes, hours, etc.) data
- Added loading indicator
- Showing tooltip
- Always showing legend
- Max Y is slightly higher than maximum of highest y value or threshold
- Adjusting chart to always show the threshold line
- Fixed
- When removing some fields like transaction type, transaction name,
chart showed no data
- Hiding a particular group (by clicking on legend item), readjusted max
Y value, but same was not reset to original when enabling the group back
benakansara added a commit that referenced this issue Jun 19, 2023
Resolves the following for APM Latency threshold rule:
- #152218
- #155489

Improvements in the preview chart:
- Showing data grouped by selected group by fields
- Showing 5 groups from each bucket
- Showing last x units (minutes, hours, etc.) data
- Added loading indicator
- Showing tooltip
- Always showing legend
- Max Y is slightly higher than maximum of highest y value or threshold
- Adjusting chart to always show the threshold line
- Fixed
- When removing some fields like transaction type, transaction name,
chart showed no data
- Hiding a particular group (by clicking on legend item), readjusted max
Y value, but same was not reset to original when enabling the group back

### Before


https://github.com/elastic/kibana/assets/69037875/03b77133-a131-4758-805b-2a9287fb7ff9

### After


https://github.com/elastic/kibana/assets/69037875/5900b74e-ee26-4d1d-a3f4-a03333808075
@benakansara
Copy link
Contributor Author

Closed by #158439, #159544

@MiriamAparicio MiriamAparicio added the apm:test-plan-done Pull request that was successfully tested during the test plan label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0
Projects
None yet
Development

No branches or pull requests

4 participants