[lens] tag cloud

[nreese]

Part of #154307
Closes #95542

PR adds tagcloud visualization to lens

[nreese]

@elasticmachine merge upstream

[stratoula]

Thanx Nathan! Now it looks great! 2 last comments from me

1. On no results the icon is not well centered and and the suggestion looks weird. We need to add the tagcloud icon there to work like the rest of the suggestions
2. We want by clicking a term to create a filter. This is already available in agg based and they share the same renderer so I feel will be easy to enable.

[markov00]

Tested locally, it looks good to me, but I've identified 2 issues:

1. there is a warning that pops up if there isn't enough room to render all the tags. Unfortunately, this warning is preserved on each data change even if a new configuration allows a full rendering of all tags. (to reproduce: build a tag cloud with agent.keyword and see the warning now, switch the field to something like geo.dest or extension.keyword. All the tags are visible but the warning remains visible)
2. It seems that only string fields are supported as tags, but if you drag and drop an IP field into the center area you can also use IPs as tags. I think both ways should allow the same type of fields. (to reproduce: with an empty tag cloud configuration drag clientIp or any IP field into the chart area to see it working, but if you try to pick up the same field from the field dropdown in the tag dimension you can't)

I'd like to rise also this (cc @MichaelMarcialis)

I suggest changing the orientation radio group to a dropdown and making the switch part of the form (with the label at the left and the switch to the right).

I'm not sure for the font-size is not super clear what does the range mean, probably a better label here could help

[nreese]

On no results the icon is not well centered and and the suggestion looks weird. We need to add the tagcloud icon there to work like the rest of the suggestions

resolved with 83bd394

We want by clicking a term to create a filter. This is already available in agg based and they share the same renderer so I feel will be easy to enable.

resolved with a482b0e

[nreese]

@markov00

there is a warning that pops up if there isn't enough room to render all the tags. Unfortunately, this warning is preserved on each data change even if a new configuration allows a full rendering of all tags. (to reproduce: build a tag cloud with agent.keyword and see the warning now, switch the field to something like geo.dest or extension.keyword. All the tags are visible but the warning remains visible)

This is an existing issue and exists in legacy agg based tag cloud visualization. Fixing this issue is outside the scope of this PR.

It seems that only string fields are supported as tags, but if you drag and drop an IP field into the center area you can also use IPs as tags. I think both ways should allow the same type of fields. (to reproduce: with an empty tag cloud configuration drag clientIp or any IP field into the chart area to see it working, but if you try to pick up the same field from the field dropdown in the tag dimension you can't)

resolved with ed2619f

I suggest changing the orientation radio group to a dropdown and making the switch part of the form (with the label at the left and the switch to the right). I'm not sure for the font-size is not super clear what does the range mean, probably a better label here could help

resolved with 062d86a

[stratoula]

Changes LGTM! I think it works fine as a technical preview visualization in Lens. We can always follow up with improvements. Thanx Nathan, great job!

the only thing I would change before merging is making the label switch and the orientation dropdown one size smaller as it is on the rest toolbar panels, for example

I am approving for not blocking this PR

[nreese]

the only thing I would change before merging is making the label switch and the orientation dropdown one size smaller as it is on the rest toolbar panels

resolved with 535f1f6

[MichaelMarcialis]

I'd like to rise also this (cc @MichaelMarcialis)

I suggest changing the orientation radio group to a dropdown and making the switch part of the form (with the label at the left and the switch to the right).

I'm not sure for the font-size is not super clear what does the range mean, probably a better label here could help

Thanks for the ping, @markov00. I agree with all of those points. Looks like @nreese has addressed them as well. Thanks, all!

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 248b12b
• Storybooks Preview

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
apm	1369	1370	+1
expressionGauge	86	87	+1
expressionHeatmap	120	121	+1
expressionPartitionVis	94	95	+1
expressionTagcloud	21	72	+51
expressionXY	151	152	+1
lens	884	893	+9
maps	978	979	+1
total			+66

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/chart-icons	76	78	+2
expressionTagcloud	5	6	+1
total			+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
expressionTagcloud	7.7KB	15.0KB	+7.2KB
lens	1.2MB	1.3MB	+7.5KB
total			+14.7KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
expressionTagcloud	0	2	+2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
expressionTagcloud	8.8KB	9.6KB	+769.0B
lens	34.9KB	35.2KB	+284.0B
total			+1.0KB

Unknown metric groups

API count

id	before	after	diff
@kbn/chart-icons	76	78	+2
expressionTagcloud	5	6	+1
total			+3

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	19	21	+2
securitySolution	413	417	+4
total			+6

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	20	22	+2
securitySolution	497	501	+4
total			+6

History

• 💔 Build #133336 failed 535f1f6
• 💚 Build #133130 succeeded 66877a9
• 💔 Build #133123 failed a58ffa1afcf6e491462cd201a2bb62a1f770919e
• 💔 Build #133106 failed e4b468c
• 💔 Build #133095 failed 83bd394

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream