Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serverless] Visualizations team changes #154307

Closed
stratoula opened this issue Apr 4, 2023 · 4 comments
Closed

[Serverless] Visualizations team changes #154307

stratoula opened this issue Apr 4, 2023 · 4 comments
Assignees
@nreese
Labels
enhancement New value added to drive a business result Feature:Vis Editor Visualization editor issues Feature:Visualizations Generic visualization features (in case no more specific feature label is available) impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

stratoula commented Apr 4, 2023 •
edited
Loading

Describe the feature:
In serverless the available editors/visualizations will be:

  • Lens
  • Vega
  • Markdown text

Timelion, aggbased will be on readonly mode, Graph will be disabled

Some features will be unavailable in v1, eventually will will add Lens feature parity for:

  • TSVB Markdown
  • Charts with small multiples

Things we need to do:

  • We will need to prepare a “read-only” mode for legacy editors (TSVB/Agg-based/Timelion)
    • Each visualization plugin will have a read-only yaml setting (each serverless product will set these yml settings)
    • Each plugin should configure and export the yaml settings for the consumers that want to know which editors/visualizations are avalable). One plugin has access only to its own yaml settings but we could do the following:
      • Create a new function on base_vis_type which will export if it is readonly or not
      • Gather everything on the visualizations plugin
      • The visualizations plugin will export this information to the consumers so no need to depend on all our plugins, only in one.
  • We need to support tagcloud in Lens
  • Visualize library
    • Will exist as a listing page, linked maybe, from the Dashboard listing page (we dont have the designs yet)
    • Reminder: The listing page renders Lens, Vega, agg based, TSVB and Maps SOs.
    • Lens, Vega, Maps will be editable
    • TSVB, Visualize will be shown but with no edit action
  • What read only means?
    • users cant edit an existing visualization but they can still see them rendered on a dashboard. Edit in dashboard menu item doesnt exist, only Convert to Lens if applicable.
    • Check if graph has an enabled congif yml, if not, add one
    • Advanced settings
      • Decided to go without advanced settings (hide them all)
      • Heatmap will soon support small mulltiples and EC solution will be the default
      • Gauges will most possibly default to vislib (if we have the redesign and the small multiples we can change this to the default but this will be configured by us and not by the user)
  • Routing
    • If the user tries to access a visualization that is on readonly mode (visualize/edit/{savedObjectId}) then we should identify if the chart type is allowed or not and redirect to 404
  • Breadcrumbs
    • We should ensure that the breadcrumbs for Vega, Lens etc are correct, should they depict the Visualize library or not?
  • Saved objects management page, should not allow to go to visualize and edit the visualization
@stratoula stratoula added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Apr 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@stratoula stratoula added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Feature:Vis Editor Visualization editor issues labels Apr 4, 2023
@stratoula stratoula changed the title [Serverless] Visualizations changes [Serverless] Visualizations team changes May 3, 2023
@stratoula
Copy link
Contributor Author

About the functional testing, we haven't figured out about the serverlerss tests yet but we could create a new suite with the readonly yaml settings set to true and test the above scenarios (no edit buttons for the readonly visualizations etc)

@stratoula
Copy link
Contributor Author

Configurina yaml settings only for serverless #156837

@nreese nreese self-assigned this May 16, 2023
@nreese nreese mentioned this issue May 16, 2023
Merged
nreese added a commit that referenced this issue May 24, 2023
@nreese @kibanamachine @stratoula
[tsvb] read only mode (#157920)
34e2625 
part of #154307

PR adds ability to put TSVB into read only mode - preventing TSVB
visualizations from being created and edited.

To test:
* start kibana with `yarn start --serverless=es`
* add `vis_type_timeseries.readOnly: true` to kibana.yml

Visualization public plugin changes:
* Removes `hideTypes` from VisualizationSetup contract. Used by Maps
plugin to set "hidden" to true for tile_map and region_map visualization
types. In 8.0, tile_map and region_map visualization type registration
moved into maps plugin so `hideTypes` no longer needed.
* Renamed vis type definition `hidden` to `disableCreate`.
* Added `disableEdit` to vis type definition.
* Hide edit link in dashboard panel options when `disableEdit` is true
* Does not display links and edit action in listing table when
`disableEdit` is true

Visualization server plugin changes:
* Add `readOnlyVisType` registry to set up contract
* Update visualization savedObject.management.getInAppUrl to return
undefined when vis type has been registered as readOnly.
* Prevents "readOnly "visualization types from being displayed in global
search results
* Prevents "readOnly "visualization types from having links in saved
object management listing table.

Timeseries server plugin changes:
* Add `readOnly` yaml configuration
* Expose `readOnly` yaml configuration to public
* When `readOnly` is true, call
VisualizationsServerSetup.registerReadOnlyVisType to mark vis type as
read only

Timeseries public plugin changes:
* Set disableCreate and disableEdit to true when `readOnly` is true

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
@nreese nreese mentioned this issue May 25, 2023
Merged
nreese added a commit that referenced this issue May 30, 2023
@nreese @kibanamachine @stratoula
[visualizations] read only config flag for vis_types (#158507)
21151dd 
Part of #154307

### Overview
PR adds `readOnly` configuration to all vis_type plugins.

### Test
* Start kibana with `yarn start --serverless=es`
* set the following yaml configuration values
    ```
    vis_type_gauge.readOnly: true
    vis_type_heatmap.readOnly: true
    vis_type_metric.readOnly: true
    vis_type_pie.readOnly: true
    vis_type_table.readOnly: true
    vis_type_tagcloud.readOnly: true
    vis_type_timelion.readOnly: true
    vis_type_timeseries.readOnly: true
    vis_type_vislib.readOnly: true
    vis_type_xy.readOnly: true
    ```

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
This was referenced May 31, 2023
Merged
Merged
nreese added a commit that referenced this issue Jun 2, 2023
@nreese @kibanamachine
input control read only (#158853)
0eab3fb 
Part of #154307

### Test
* Start kibana with `yarn start --serverless=es`
* set the following yaml configuration values
    ```
    input_control_vis.readOnly: true
    ```

---------

Co-authored-by: kibanamachine <[email protected]>
@nreese nreese mentioned this issue Jun 2, 2023
Merged
nreese added a commit that referenced this issue Jun 8, 2023
@nreese @kibanamachine @stratoula
[lens] tag cloud (#157751)
ec62e15 
Part of #154307
Closes #95542

PR adds tagcloud visualization to lens

<img width="600" alt="Screen Shot 2023-05-31 at 1 11 00 PM"
src="https://github.com/elastic/kibana/assets/373691/f54f76a3-9757-4a00-ac65-a203e5bb113a">

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
nreese added a commit that referenced this issue Jun 8, 2023
@nreese @kibanamachine
[lens] Add significant terms support as ranking function in Top Values (
59eb4ea 
#158962)

Part of #154307
Closes #116421

PR adds `Significance` selection to `Rank by` select. When selected, top
values are fetched with [significant_terms
aggregation](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-bucket-significantterms-aggregation.html)

<img width="600" alt="Screen Shot 2023-06-02 at 12 56 29 PM"
src="https://github.com/elastic/kibana/assets/373691/b6a4f70a-4121-4c38-b6d5-7d46dc48ab1a">

---------

Co-authored-by: kibanamachine <[email protected]>
@nreese nreese mentioned this issue Jun 12, 2023
Merged
nreese added a commit that referenced this issue Jun 12, 2023
@nreese @kibanamachine @stratoula
legacy agg vis tag cloud convert to lens (#159348)
e8e5cec 
Part of #154307

Add convert to lens logic for tag cloud visualization

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
@nreese nreese mentioned this issue Jun 13, 2023
Merged
nreese added a commit that referenced this issue Jun 14, 2023
@nreese @kibanamachine @stratoula
[lens] significant terms convert to lens (#159580)
57a1775 
Part of #154307

Update convert to lens functionality to support significant terms
aggregation

<img width="500" alt="Screen Shot 2023-06-13 at 8 58 09 AM"
src="https://github.com/elastic/kibana/assets/373691/949199ee-24e2-45d0-84b1-512698abecb4">

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
@nreese
Copy link
Contributor

nreese commented Jun 15, 2023

Closing, all items have been completed

@nreese nreese closed this as completed Jun 15, 2023
@andrewkroh andrewkroh mentioned this issue Jul 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
enhancement New value added to drive a business result Feature:Vis Editor Visualization editor issues Feature:Visualizations Generic visualization features (in case no more specific feature label is available) impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nreese @elasticmachine @stratoula