Fix #15517: Link to the new SHA512 checksum #15675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also check the integrity directly
jbudz
reviewed
Jan 22, 2018
| <1> Compare the SHA produced by `sha1sum` or `shasum` with the | ||
| https://artifacts.elastic.co/downloads/kibana/kibana-{version}-linux-x86_64.tar.gz.sha1[published SHA]. | ||
| <1> Compares the SHA of the downloaded `.tar.gz` archive and the published checksum, which should output | ||
| `kibana-{version}-linux-x86_64.tar.gz: OK`. |
There was a problem hiding this comment.
The {version} variable doesn't seem to work with inline code blocks. @debadair any ideas if there's a workaround? I couldn't find anything.
|
Keen eye, I introduced the same problem at https://www.elastic.co/guide/en/elasticsearch/reference/6.0/zip-targz.html#install-zip. If this is not possible, I'll rephrase it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't provide SHA1 any more for 6.0+ artefacts, so the link is currently broken. Also switched to checking the integrity directly instead of comparing hashes.
Related blog post: https://www.elastic.co/blog/sha512-checksums-for-elastic-stack-artifacts
This fixes #15517 and is similar to an Elasticsearch PR.
Will cherry-pick to 6.0, 6.1, and 6.x if approved.