Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to the new SHA512 checksums and check the integrity directly #27524

Merged
merged 1 commit into from
Nov 30, 2017

Conversation

xeraa
Copy link
Contributor

@xeraa xeraa commented Nov 24, 2017

We don't provide SHA1 any more for 6.0+ artefacts, so the link is currently broken. Also switched to checking the integrity directly instead of comparing hashes.

Related blog post: https://www.elastic.co/blog/sha512-checksums-for-elastic-stack-artifacts ( @mgreau )

Will cherrypick to 6.0 and 6.1 branches if approved.

@xeraa xeraa added the >docs General docs changes label Nov 24, 2017
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jasontedor
Copy link
Member

Please also cherry-pick to the 6.x branch.

Copy link
Member

@mgreau mgreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @xeraa

@jasontedor jasontedor merged commit 64ca0fe into elastic:master Nov 30, 2017
jasontedor pushed a commit that referenced this pull request Nov 30, 2017
This commit updates the docs for the new SHA-512 checksums that are
supported for official plugins.

Relates #27524
jasontedor pushed a commit that referenced this pull request Nov 30, 2017
This commit updates the docs for the new SHA-512 checksums that are
supported for official plugins.

Relates #27524
jasontedor pushed a commit that referenced this pull request Nov 30, 2017
This commit updates the docs for the new SHA-512 checksums that are
supported for official plugins.

Relates #27524
@xeraa xeraa deleted the fix-sha512-download-docs branch November 30, 2017 13:44
@xeraa
Copy link
Contributor Author

xeraa commented Nov 30, 2017

Thanks for merging, @jasontedor — I got too busy with community work the last few days...

@jasontedor
Copy link
Member

No worries @xeraa, thank you for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants