[D4C] additional error handling for 'block' action added + policy editor UI fixes #156629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ness in the yaml -> json conversion, and general -> yaml view switching
mitodrummer
added
bug
mitodrummer
added
the
release_note:skip
mitodrummer
commented
May 4, 2023
| @@ -99,28 +99,6 @@ describe('<ControlGeneralView />', () => { | |||
| } | |||
| }); | |||
|
|
|||
| it('should prevent user from adding a process response if no there are no process selectors', async () => { | |||
There was a problem hiding this comment.
removed as this was done to avoid a deeper issue which is now fixed.
norrietaylor
approved these changes
May 4, 2023
…todrummer/kibana into d4c_ui_fixes_and_block_error_handling
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
LGTM! Thanks @mitodrummer ! |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 4, 2023
…tor UI fixes (elastic#156629) ## Summary This PR addresses adding safeguards to the 'block' action around FIM capabilities in D4C (cloud_defend) see: https://github.com/elastic/cloud-defend/issues/337 It also fixes a few bugs: 1. updates not being reflected in the yaml editor side when changed on the UI side (after yaml editor viewed for first time). 2. the yaml -> json conversion function was mutating the original selector/response when deleting the type property. which would cause the item to dissapear under certain situations. ### Screenshots   ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 587cca4)
kibanamachine
added a commit
that referenced
this pull request
May 5, 2023
…cy editor UI fixes (#156629) (#156763) # Backport This will backport the following commits from `main` to `8.8`: - [[D4C] additional error handling for 'block' action added + policy editor UI fixes (#156629)](#156629) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Karl Godard","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-04T23:03:26Z","message":"[D4C] additional error handling for 'block' action added + policy editor UI fixes (#156629)\n\n## Summary\r\n\r\nThis PR addresses adding safeguards to the 'block' action around FIM\r\ncapabilities in D4C (cloud_defend)\r\nsee: https://github.com/elastic/cloud-defend/issues/337\r\n\r\nIt also fixes a few bugs:\r\n1. updates not being reflected in the yaml editor side when changed on\r\nthe UI side (after yaml editor viewed for first time).\r\n2. the yaml -> json conversion function was mutating the original\r\nselector/response when deleting the type property. which would cause the\r\nitem to dissapear under certain situations.\r\n\r\n### Screenshots\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"587cca49eed701951428684ce2c80e0554d2207d","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","backport:prev-minor","Team: Cloud Native Integrations","v8.8.0","v8.9.0"],"number":156629,"url":"https://github.com/elastic/kibana/pull/156629","mergeCommit":{"message":"[D4C] additional error handling for 'block' action added + policy editor UI fixes (#156629)\n\n## Summary\r\n\r\nThis PR addresses adding safeguards to the 'block' action around FIM\r\ncapabilities in D4C (cloud_defend)\r\nsee: https://github.com/elastic/cloud-defend/issues/337\r\n\r\nIt also fixes a few bugs:\r\n1. updates not being reflected in the yaml editor side when changed on\r\nthe UI side (after yaml editor viewed for first time).\r\n2. the yaml -> json conversion function was mutating the original\r\nselector/response when deleting the type property. which would cause the\r\nitem to dissapear under certain situations.\r\n\r\n### Screenshots\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"587cca49eed701951428684ce2c80e0554d2207d"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156629","number":156629,"mergeCommit":{"message":"[D4C] additional error handling for 'block' action added + policy editor UI fixes (#156629)\n\n## Summary\r\n\r\nThis PR addresses adding safeguards to the 'block' action around FIM\r\ncapabilities in D4C (cloud_defend)\r\nsee: https://github.com/elastic/cloud-defend/issues/337\r\n\r\nIt also fixes a few bugs:\r\n1. updates not being reflected in the yaml editor side when changed on\r\nthe UI side (after yaml editor viewed for first time).\r\n2. the yaml -> json conversion function was mutating the original\r\nselector/response when deleting the type property. which would cause the\r\nitem to dissapear under certain situations.\r\n\r\n### Screenshots\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"587cca49eed701951428684ce2c80e0554d2207d"}}]}] BACKPORT--> Co-authored-by: Karl Godard <[email protected]>
jloleysens
added a commit
that referenced
this pull request
May 5, 2023
\r\n\r\n\r\n###](https://user-images.githubusercontent.com/16198204/236331957-65fa0a5b-cab7-427c-998d-a3eea77a2820.png)\r\n\r\n\r\n\r\n\r\n###){kind=link}
* main: (153 commits)
[Security Solution] {{state.signals_count}} Object not working (#156472) (#156707)
[Synthetics] refresh data on visualization scrubbing (#156777)
[RAM] Docs for slack improvements (#153885)
[RAM] Alert search bar only KQL (#155947)
[ML] Functional tests - stabilize export job tests (#156586)
[Saved Search] Update saved search schema to allow empty `sort` arrays (#156769)
[ML] Rename `curated` model type to `elastic` (#156684)
[Discover] Enable sharing for text based languages (#156652)
[api-docs] 2023-05-05 Daily api_docs build (#156781)
Upgrade EUI to v77.2.2 (#155208)
[RAM][Maintenance Window][8.8]Fix window maintenance workflow (#156427)
[DOCS] Case file attachments (#156459)
[D4C] additional error handling for 'block' action added + policy editor UI fixes (#156629)
[Enterprise Search] refactor(SearchApplications): rename telemetry ids (#156733)
[Enterprise Search] Add telemetry to ELSER deployment buttons + error (#156545)
[Security Solution] fixes Data Quality dashboard errors when a `basePath` is configured (#156233)
[Logs onboarding] StepsFooter outside of main panel (#156686)
[Security Solution] Add a migration to unmute custom Security Solution rules (#156593)
[Enterprise Search][Behavioral Analytics] Update formulas (#156704)
Add API Events to Endpoint Security Advanced Policy (#156718)
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses adding safeguards to the 'block' action around FIM capabilities in D4C (cloud_defend)
see: https://github.com/elastic/cloud-defend/issues/337
It also fixes a few bugs:
Screenshots
Checklist
Delete any items that are not applicable to this PR.