Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Functional tests - stabilize export job tests #156586

Merged
merged 3 commits into from
May 5, 2023
Merged

[ML] Functional tests - stabilize export job tests #156586

merged 3 commits into from
May 5, 2023

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented May 3, 2023 •
edited by kibanamachine
Loading

Summary

This PR stabilizes the export job tests by making sure the export success toast is closed before moving on to the next test. As part of that, the toasts service got two new methods dismissAllToastsWithChecks and assertToastCount.

Closes #150558

@pheyos
Copy link
Member Author

pheyos commented May 3, 2023 •
edited
Loading

Checking test stability in a flaky test runner job ... no failure in 50 runs ✔️

@pheyos pheyos self-assigned this May 4, 2023
@pheyos pheyos added :ml release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.8.0 v8.9.0 labels May 4, 2023
@pheyos pheyos marked this pull request as ready for review May 4, 2023 11:03
@pheyos pheyos requested a review from a team as a code owner May 4, 2023 11:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

jgowdyelastic
jgowdyelastic approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peteharverson
peteharverson approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dmlemeshko
dmlemeshko approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pheyos

@pheyos pheyos merged commit dd1fd26 into elastic:main May 5, 2023
@pheyos pheyos deleted the stabilize_export_job_tests branch May 5, 2023 07:17
@kibanamachine kibanamachine mentioned this pull request May 5, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 5, 2023
@pheyos
[ML] Functional tests - stabilize export job tests (elastic#156586)
8382b45 
This PR stabilizes the export job tests by making sure the export
success toast is closed before moving on to the next test. As part of
that, the toasts service got two new methods
`dismissAllToastsWithChecks` and `assertToastCount`.

(cherry picked from commit dd1fd26)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jloleysens added a commit that referenced this pull request May 5, 2023
@jloleysens
Merge branch 'main' into versioned-router-and-oas
630343b 
* main: (153 commits)
  [Security Solution] {{state.signals_count}} Object not working (#156472) (#156707)
  [Synthetics] refresh data on visualization scrubbing (#156777)
  [RAM] Docs for slack improvements (#153885)
  [RAM] Alert search bar only KQL (#155947)
  [ML] Functional tests - stabilize export job tests (#156586)
  [Saved Search] Update saved search schema to allow empty `sort` arrays (#156769)
  [ML] Rename `curated` model type to `elastic` (#156684)
  [Discover] Enable sharing for text based languages (#156652)
  [api-docs] 2023-05-05 Daily api_docs build (#156781)
  Upgrade EUI to v77.2.2 (#155208)
  [RAM][Maintenance Window][8.8]Fix window maintenance workflow (#156427)
  [DOCS] Case file attachments (#156459)
  [D4C] additional error handling for 'block' action added + policy editor UI fixes (#156629)
  [Enterprise Search] refactor(SearchApplications): rename telemetry ids (#156733)
  [Enterprise Search] Add telemetry to ELSER deployment buttons + error (#156545)
  [Security Solution] fixes Data Quality dashboard errors when a `basePath` is configured (#156233)
  [Logs onboarding] StepsFooter outside of main panel (#156686)
  [Security Solution] Add a migration to unmute custom Security Solution rules (#156593)
  [Enterprise Search][Behavioral Analytics] Update formulas (#156704)
  Add API Events to Endpoint Security Advanced Policy (#156718)
  ...
kibanamachine added a commit that referenced this pull request May 5, 2023
@kibanamachine @pheyos
[8.8] [ML] Functional tests - stabilize export job tests (#156586) (#…
36d827a 
…156790)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[ML] Functional tests - stabilize export job tests
(#156586)](#156586)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Oskamp","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-05T07:17:04Z","message":"[ML]
Functional tests - stabilize export job tests (#156586)\n\nThis PR
stabilizes the export job tests by making sure the export\r\nsuccess
toast is closed before moving on to the next test. As part of\r\nthat,
the toasts service got two new methods\r\n`dismissAllToastsWithChecks`
and
`assertToastCount`.","sha":"dd1fd2647a453fe9ad233d3afc9848b507c945da","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","backport:prev-minor","v8.8.0","v8.9.0"],"number":156586,"url":"https://github.com/elastic/kibana/pull/156586","mergeCommit":{"message":"[ML]
Functional tests - stabilize export job tests (#156586)\n\nThis PR
stabilizes the export job tests by making sure the export\r\nsuccess
toast is closed before moving on to the next test. As part of\r\nthat,
the toasts service got two new methods\r\n`dismissAllToastsWithChecks`
and
`assertToastCount`.","sha":"dd1fd2647a453fe9ad233d3afc9848b507c945da"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156586","number":156586,"mergeCommit":{"message":"[ML]
Functional tests - stabilize export job tests (#156586)\n\nThis PR
stabilizes the export job tests by making sure the export\r\nsuccess
toast is closed before moving on to the next test. As part of\r\nthat,
the toasts service got two new methods\r\n`dismissAllToastsWithChecks`
and
`assertToastCount`.","sha":"dd1fd2647a453fe9ad233d3afc9848b507c945da"}}]}]
BACKPORT-->

Co-authored-by: Robert Oskamp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@dmlemeshko dmlemeshko dmlemeshko approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees

@pheyos pheyos

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) :ml release_note:skip Skip the PR/issue when compiling release notes v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
7 participants
@pheyos @elasticmachine @kibana-ci @kibanamachine @peteharverson @dmlemeshko @jgowdyelastic