Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add button to enter dashboard edit mode from listing page #15645

Merged
merged 2 commits into from
Dec 21, 2017

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Dec 15, 2017

fixes #10914

Add button to launch directly into dashboard edit mode from dashboard listing page

screen shot 2017-12-15 at 4 26 31 pm

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can we add a similar button to the Visualize listing table? These tables are so similar that I feel they should have functionality parity.

@nreese
Copy link
Contributor Author

nreese commented Dec 18, 2017

@cjcenizal The visualize listing page always takes you to edit mode so the button is not really needed

Copy link
Contributor

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@nreese
Copy link
Contributor Author

nreese commented Dec 18, 2017

@stacey-gammon What about dashboard only mode? Should the column not be displayed?

@stacey-gammon
Copy link
Contributor

ohhhh, great call on thinking about dashboard only mode @nreese. Yes, I would say it should not be exposed in that case.

@nreese nreese merged commit c4d5018 into elastic:master Dec 21, 2017
nreese added a commit to nreese/kibana that referenced this pull request Dec 21, 2017
)

* add button to enter dashboard edit mode from listing page

* do not show actions column when dashboard is in read only mode
nreese added a commit that referenced this pull request Dec 21, 2017
…15741)

* add button to enter dashboard edit mode from listing page

* do not show actions column when dashboard is in read only mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to enter edit mode from landing page
3 participants