add button to enter dashboard edit mode from listing page (#15645) (#…

…15741) * add button to enter dashboard edit mode from listing page * do not show actions column when dashboard is in read only mode
elastic · Dec 21, 2017 · 09fba75 · 09fba75
1 parent 085dee4
commit 09fba75
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/src/core_plugins/kibana/public/dashboard/listing/dashboard_listing.html b/src/core_plugins/kibana/public/dashboard/listing/dashboard_listing.html
@@ -177,6 +177,15 @@
               </span>
             </button>
           </th>
+
+          <th
+            ng-if="!listingController.hideWriteControls"
+            scope="col"
+            class="kuiTableHeaderCell"
+            width="80px"
+          >
+            <div class="kuiTableHeaderCell__liner">Actions</div>
+          </th>
         </tr>
       </thead>
 
@@ -215,6 +224,20 @@
               {{ item.description }}
             </div>
           </td>
+          <td
+            ng-if="!listingController.hideWriteControls"
+            class="kuiTableRowCell kuiTableRowCell--wrap"
+          >
+            <div class="kuiTableRowCell__liner">
+              <a
+                class="kuiMenuButton kuiMenuButton--basic"
+                data-test-subj="dashboardListingTitleEditLink-{{item.title.split(' ').join('-')}}"
+                ng-href="{{ listingController.getEditUrlForItem(item) }}"
+              >
+                Edit
+              </a>
+            </div>
+          </td>
         </tr>
       </tbody>
     </table>

diff --git a/src/core_plugins/kibana/public/dashboard/listing/dashboard_listing.js b/src/core_plugins/kibana/public/dashboard/listing/dashboard_listing.js
@@ -156,6 +156,10 @@ export function DashboardListingController($injector, $scope, $location) {
     return `#${createDashboardEditUrl(item.id)}`;
   };
 
+  this.getEditUrlForItem = function getEditUrlForItem(item) {
+    return `#${createDashboardEditUrl(item.id)}?_a=(viewMode:edit)`;
+  };
+
   this.getCreateDashboardHref = function getCreateDashboardHref() {
     return `#${DashboardConstants.CREATE_NEW_DASHBOARD_URL}`;
   };