Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs onboarding] Add select logs step #156182

Merged
merged 15 commits into from
May 4, 2023

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Apr 28, 2023

Closes #154941

image

@yngrdyn yngrdyn requested a review from a team as a code owner April 28, 2023 14:25
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@yngrdyn yngrdyn added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.9.0 labels Apr 28, 2023
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just small stuff, mostly because the figma design was updated since this PR started.

)}
iconType="desktop"
onClick={() => {
setState({ ...getState(), logsType: 'log-file' });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not 100% sure if we should update the state before continuing to the next step, or if the next step will be specific for streaming log files. Like maybe the fact that they are in configureLogs step already implies they clicked this option. We can leave it in for now, but we may want to clean it up later if it's not necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree, but I think we will discover more about it as we advance in the topic.

);
}

function OptionCard({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once more of these steps get merged, we will eventually want to used shared components for these cards and sections.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityOnboarding 35 34 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityOnboarding 28.8KB 32.1KB +3.2KB
Unknown metric groups

ESLint disabled in files

id before after diff
observabilityOnboarding 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
observabilityOnboarding 5 6 +1
securitySolution 478 481 +3
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yngrdyn yngrdyn merged commit 52b2e38 into elastic:main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs Onboarding] Log type selection page
4 participants