-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs onboarding] Add select logs step #156182
[Logs onboarding] Add select logs step #156182
Conversation
…928' into logs-onboarding-select-logs-154941
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
...k/plugins/observability_onboarding/public/components/app/custom_logs/wizard/collect_logs.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just small stuff, mostly because the figma design was updated since this PR started.
...ck/plugins/observability_onboarding/public/components/app/custom_logs/wizard/select_logs.tsx
Outdated
Show resolved
Hide resolved
...ck/plugins/observability_onboarding/public/components/app/custom_logs/wizard/select_logs.tsx
Outdated
Show resolved
Hide resolved
)} | ||
iconType="desktop" | ||
onClick={() => { | ||
setState({ ...getState(), logsType: 'log-file' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not 100% sure if we should update the state before continuing to the next step, or if the next step will be specific for streaming log files. Like maybe the fact that they are in configureLogs
step already implies they clicked this option. We can leave it in for now, but we may want to clean it up later if it's not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree, but I think we will discover more about it as we advance in the topic.
...ck/plugins/observability_onboarding/public/components/app/custom_logs/wizard/select_logs.tsx
Outdated
Show resolved
Hide resolved
...ck/plugins/observability_onboarding/public/components/app/custom_logs/wizard/select_logs.tsx
Outdated
Show resolved
Hide resolved
...ck/plugins/observability_onboarding/public/components/app/custom_logs/wizard/select_logs.tsx
Outdated
Show resolved
Hide resolved
...ck/plugins/observability_onboarding/public/components/app/custom_logs/wizard/select_logs.tsx
Outdated
Show resolved
Hide resolved
); | ||
} | ||
|
||
function OptionCard({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once more of these steps get merged, we will eventually want to used shared components for these cards and sections.
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Closes #154941