Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Fix flaky saved objects tagging functional test #155974

Merged
merged 1 commit into from
Apr 28, 2023
Merged

[Discover] Fix flaky saved objects tagging functional test #155974

merged 1 commit into from
Apr 28, 2023

Conversation

kertal
Copy link
Member

@kertal kertal commented Apr 27, 2023 •
edited
Loading

Summary

This PR fixes an occasional flaky test of Discover's saved search tagging
Flaky test runner 100x says it's ok:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2179

Fixes #150249

Checklist

@kertal kertal self-assigned this Apr 27, 2023
@kertal kertal added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. release_note:skip Skip the PR/issue when compiling release notes Feature:Discover Discover Application labels Apr 27, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

@kertal kertal marked this pull request as ready for review April 27, 2023 17:14
@kertal kertal requested a review from a team as a code owner April 27, 2023 17:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal requested a review from a team April 27, 2023 17:15
sebelga
sebelga approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kertal kertal merged commit e7a3a48 into elastic:main Apr 28, 2023
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga sebelga approved these changes

@lukasolson lukasolson lukasolson approved these changes

Assignees

@kertal kertal

Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.9.0
Projects
None yet
Milestone
No milestone
6 participants
@kertal @kibana-ci @elasticmachine @lukasolson @sebelga @kibanamachine