Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Screenshotting] minor improvement to chromium version-check script #155806

Merged

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Apr 25, 2023

Adds a minor improvement to the script for checking the version of Chromium. The change shows the download path for each type of OS for which we can use the stock build for the screenshotting feature.

Forward-ported from this fix in 8.7: #155313

Adds a minor improvement to the script for checking the version of
Chromium. The change shows the download path for each type of OS for
which we can use the stock build for the screenshotting feature.
@tsullivan tsullivan requested a review from a team as a code owner April 25, 2023 22:17
@tsullivan tsullivan added release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Apr 25, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@tsullivan tsullivan self-assigned this Apr 25, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 397 400 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 477 480 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tsullivan

@tsullivan tsullivan merged commit 6a6be92 into elastic:main Apr 26, 2023
@tsullivan tsullivan deleted the screenshotting/script-improvement-1 branch April 26, 2023 20:25
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants