[Screenshotting] fix revision number used for mac and windows downloads of chromium #155313

tsullivan · 2023-04-19T19:29:25Z

Summary

Fixes an issue where Mac and Windows Chromium downloads are referencing a bucket from an older version of Kibana.

Checklist

Unit or functional tests were updated or added to match the most common scenarios
- This has not completed since designing tests around this will take some time: [Screenshotting] Test needed for validating the installed version of Chromium. #155753

Release note

Fixed an issue for Windows and Mac where the Reporting plugin downloaded an older version of Chromium. All OS types are now synchronized to 107.0.5296.0

tsullivan · 2023-04-19T20:45:02Z

src/dev/chromium_version.ts

@@ -46,7 +46,7 @@ async function getChromiumRevision(
  kibanaPuppeteerVersion: PuppeteerRelease,
  log: ToolingLog
 ): Promise<ChromiumRevision> {
-  const url = `https://raw.githubusercontent.com/puppeteer/puppeteer/v${kibanaPuppeteerVersion}/src/revisions.ts`;
+  const url = `https://raw.githubusercontent.com/puppeteer/puppeteer/v${kibanaPuppeteerVersion}/packages/puppeteer-core/src/revisions.ts`;


This was needed to make the node ./scripts/chromium_version.js command work again

tsullivan · 2023-04-19T20:45:17Z

src/dev/chromium_version.ts

  log.info(`Found Chromium commit ${commit} from revision ${revision}.`);
+  log.info(`Mac x64 download:     ${baseUrl}/Mac/${revision}/chrome-mac.zip`);
+  log.info(`Mac ARM download:     ${baseUrl}/Mac_Arm/${revision}/chrome-mac.zip`);
+  log.info(`Windows x64 download: ${baseUrl}/Win/${revision}/chrome-win.zip`);


added these as a testing shortcut

tsullivan · 2023-04-19T20:46:32Z

x-pack/plugins/reporting/server/routes/diagnostic/screenshot.ts

+          body = {
+            success: true,
+            help: [],
+            logs: info.join('\n'),


The response from the diagnostic/screenshot API has a logs field - but that was never used for anything useful.

This PR uses that field to add version info that we now capture during screenshot generation. This info can be found in the network inspector during testing the diagnostic API.

Dosant

Tim, you've made quite a bit of nice changes apart from just updating the revision. I guess we also need to port them to main

tsullivan · 2023-04-25T01:48:56Z

x-pack/plugins/screenshotting/server/screenshots/get_pdf.ts

@@ -27,6 +27,7 @@ export async function getPdf(
      data: await browser.printA4Pdf({ title, ...options }),
      title: null,
      description: null,
+      versionInfo: await browser.getVersion(),


We really don't need there, since the version info is only needed for the tests. This PR tests the version string by getting a screenshot and using the Screenshot interface. Taking a screenshot is the easiest way to start interacting with the browser driver, which has the getVersion() method and we don't have access to that elsewhere. Unfortunately, this affects everything that returns a screenshot.

tsullivan · 2023-04-25T01:49:42Z

@Dosant I want to try solving the problem a different way. The problem is: how to test the Chromium version string in a running instance. For now, I will back out the test changes that have this impacts to the Screenshot interface, since it got messy. I'll change this PR to just make the correction to the revision number.

kibana-ci · 2023-04-25T06:23:54Z

💚 Build Succeeded

Buildkite Build
Commit: d6dc928

Metrics [docs]

✅ unchanged

History

💚 Build #122763 succeeded 0bd08a6deb16843fef47715c880352bc66c66682
💔 Build #122747 failed 2682669
💔 Build #121363 failed 8eb2e36a3d6a10b626ca535e48d51542cac880b8
💔 Build #121329 failed 38b13b5cd651027318fb0809e44397de00ea47e1
💚 Build #121307 succeeded 9490bde7a115d357e3959c796e7885dc54a7eba4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elasticmachine · 2023-04-25T13:57:38Z

Pinging @elastic/appex-sharedux (Team:SharedUX)

Dosant

Makes sense Tim! totally agree

…ds of chromium (elastic#155313) ## Summary Closes elastic#155681 Fixes an issue where Mac and Windows Chromium downloads are referencing a bucket from an older version of Kibana. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - This has not completed since designing tests around this will take some time: elastic#155753 ### Release note Fixed an issue for Windows and Mac where the Reporting plugin downloaded an older version of Chromium. All OS types are now synchronized to 107.0.5296.0 (cherry picked from commit 4217ec2)

…ds of chromium (elastic#155313) Closes elastic#155681 Fixes an issue where Mac and Windows Chromium downloads are referencing a bucket from an older version of Kibana. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - This has not completed since designing tests around this will take some time: elastic#155753 Fixed an issue for Windows and Mac where the Reporting plugin downloaded an older version of Chromium. All OS types are now synchronized to 107.0.5296.0 (cherry picked from commit 4217ec2)

tsullivan · 2023-04-25T18:12:28Z

💚 All backports created successfully

Status	Branch	Result
✅	8.6
✅	8.5
✅	8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…155806) Adds a minor improvement to the script for checking the version of Chromium. The change shows the download path for each type of OS for which we can use the stock build for the screenshotting feature. Forward-ported from this fix in 8.7: #155313

tsullivan added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Apr 19, 2023

tsullivan requested a review from Dosant April 19, 2023 19:29

tsullivan commented Apr 19, 2023

View reviewed changes

Dosant approved these changes Apr 20, 2023

View reviewed changes

Dosant self-requested a review April 20, 2023 08:59

tsullivan added 14 commits April 24, 2023 18:12

Extend the headless driver with methods for browser version

68dcc0c

Call browser.getVersion in screenshot generation

d8d33af

Use browser version for diagnostic info

3d71030

make versionInfo part of the Screenshot interface

797aeae

cleanup

ac23977

fix success flag

7fcb307

Clean up version response

4c67b9d

create api integration test to match the set version

e39b50a

fix revision number used for mac and windows downloads of chromium

f29fbf9

fix chromium version update script

2ccd240

fix chromium archive & binary checksums

032ee6e

Call browser.getVersion in screenshot generation

e5d8ddc

make versionInfo part of the Screenshot interface

bac2230

cleanup

6067e25

tsullivan force-pushed the fix/chromium-revision-number branch from 032fef8 to 6067e25 Compare April 25, 2023 01:14

tsullivan added 2 commits April 24, 2023 18:22

mock getVersion

b5929c0

fix ts

2682669

tsullivan force-pushed the fix/chromium-revision-number branch from 4eeff8e to 2682669 Compare April 25, 2023 01:34

tsullivan commented Apr 25, 2023

View reviewed changes

tsullivan mentioned this pull request Apr 25, 2023

[Screenshotting] Incorrect revision number used for mac and windows downloads of chromium #155681

Closed

tsullivan added v8.4.4 v8.5.4 labels Apr 25, 2023

tsullivan added v8.6.3 v8.7.2 labels Apr 25, 2023

revert the changes for testing

d6dc928

tsullivan force-pushed the fix/chromium-revision-number branch from 0bd08a6 to d6dc928 Compare April 25, 2023 05:25

tsullivan marked this pull request as ready for review April 25, 2023 13:57

Dosant approved these changes Apr 25, 2023

View reviewed changes

tsullivan added the release_note:fix label Apr 25, 2023

tsullivan mentioned this pull request Apr 25, 2023

[Screenshotting] Test needed for validating the installed version of Chromium. #155753

Open

tsullivan merged commit 4217ec2 into elastic:8.7 Apr 25, 2023

This was referenced Apr 25, 2023

[8.6] [Screenshotting] fix revision number used for mac and windows downloads of chromium (#155313) #155756

Closed

[8.5] [Screenshotting] fix revision number used for mac and windows downloads of chromium (#155313) #155757

Closed

tsullivan mentioned this pull request Apr 25, 2023

[8.4] [Screenshotting] fix revision number used for mac and windows downloads of chromium (#155313) #155758

Closed

tsullivan mentioned this pull request Apr 25, 2023

[Screenshotting] minor improvement to chromium version-check script #155806

Merged

tsullivan deleted the fix/chromium-revision-number branch November 21, 2023 23:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Screenshotting] fix revision number used for mac and windows downloads of chromium #155313

[Screenshotting] fix revision number used for mac and windows downloads of chromium #155313

tsullivan commented Apr 19, 2023 •

edited

Loading

tsullivan Apr 19, 2023

tsullivan Apr 19, 2023

tsullivan Apr 19, 2023 •

edited

Loading

Dosant left a comment

tsullivan Apr 25, 2023

tsullivan commented Apr 25, 2023

kibana-ci commented Apr 25, 2023

elasticmachine commented Apr 25, 2023

Dosant left a comment

tsullivan commented Apr 25, 2023

[Screenshotting] fix revision number used for mac and windows downloads of chromium #155313

[Screenshotting] fix revision number used for mac and windows downloads of chromium #155313

Conversation

tsullivan commented Apr 19, 2023 • edited Loading

Summary

Checklist

Release note

tsullivan Apr 19, 2023

Choose a reason for hiding this comment

tsullivan Apr 19, 2023

Choose a reason for hiding this comment

tsullivan Apr 19, 2023 • edited Loading

Choose a reason for hiding this comment

Dosant left a comment

Choose a reason for hiding this comment

tsullivan Apr 25, 2023

Choose a reason for hiding this comment

tsullivan commented Apr 25, 2023

kibana-ci commented Apr 25, 2023

💚 Build Succeeded

Metrics [docs]

History

elasticmachine commented Apr 25, 2023

Dosant left a comment

Choose a reason for hiding this comment

tsullivan commented Apr 25, 2023

💚 All backports created successfully

Questions ?

tsullivan commented Apr 19, 2023 •

edited

Loading

tsullivan Apr 19, 2023 •

edited

Loading