[HTTP] Switch default handler resolution based on Kibana config #155142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
added
Feature:http
Team:Core
jloleysens
force-pushed
the
serverless-flag-for-versioned-http-resolvers
branch
4 times, most recently
from
bba7810
to
26a7dab
Compare
…ding from environment
jloleysens
force-pushed
the
serverless-flag-for-versioned-http-resolvers
branch
from
26a7dab
to
06b1a88
Compare
jloleysens
commented
Apr 19, 2023
| @@ -194,7 +194,7 @@ describe('Versioned route', () => { | |||
| ); | |||
|
|
|||
| const kibanaResponse = await handler!( | |||
| { core: { env: { mode: { dev: true } } } } as any, | |||
| {} as any, | |||
There was a problem hiding this comment.
Unrelated to this PR, just cleaning up some unnecessary mock data
|
Pinging @elastic/kibana-core (Team:Core) |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @jloleysens |
TinaHeiligers
approved these changes
Apr 19, 2023
| @@ -142,7 +144,7 @@ export class Router<Context extends RequestHandlerContextBase = RequestHandlerCo | |||
| public readonly routerPath: string, | |||
| private readonly log: Logger, | |||
| private readonly enhanceWithContext: ContextEnhancer<any, any, any, any, any>, | |||
| private readonly options: RouterOptions = { isDev: false } | |||
| private readonly options: RouterOptions = { isDev: false, isServerless: false } | |||
There was a problem hiding this comment.
We could read the default from a pseudo-config file somewhere. Defaults set within a package are sometimes hard to track down.
This was referenced Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When launching Kibana in serverless mode (i.e., with the
--serverless=...flag we need to by default resolve to the newest request handlers, otherwise to the oldest request handler.The approach taken in this PR is the same as with #154907.
Checklist