Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serverless] Do not reach out to env.cliArgs.serverless #155912

Closed
afharo opened this issue Apr 26, 2023 · 1 comment · Fixed by #179925
Closed

[Serverless] Do not reach out to env.cliArgs.serverless #155912

afharo opened this issue Apr 26, 2023 · 1 comment · Fixed by #179925
Assignees
@afharo
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture

Comments

@afharo
Copy link
Member

afharo commented Apr 26, 2023 •
edited
Loading

Adding this for BWC. I noticed we are leveraging it in #155142.

IMO, we should either change Env to expose mode.serverless: true (instead of referring to the cliArgs), or, even better: expose the behavior under configuration that can be set in serverless.yml.

Originally posted by @afharo in #155754 (comment)
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 26, 2023
@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture and removed needs-team Issues missing a team label labels Apr 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

This was referenced Apr 26, 2023
Merged
Merged
Closed
@afharo afharo mentioned this issue Apr 3, 2024
Merged
1 task
@afharo afharo self-assigned this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afharo afharo

Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minimize use of cliArgs.serverless afharo/kibana
2 participants
@afharo @elasticmachine