-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SecuritySolution] Migrate away from browser-side SO client #154174
Conversation
b25f479
to
a881f4d
Compare
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for doing it Angela 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @angorayc, this PR doesn't seem related to the @elastic/security-detections-response-rules team. However, our review is required due to changes in the security_solution/server/utils
directory. I briefly looked through the changes in that folder, and they seem pretty domain-specific. Could you please move them to a folder belonging to the team maintaining that area? This way, code ownership will be aligned, and we won't receive reviews for code we don't support.
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Summary
Issue: #154040
Apis added:
Security Solution
or Create a Security Solution tag if no results foundGET /internal/tags
GET /internal/dashboards
Checklist
Delete any items that are not applicable to this PR.