Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution] Migrate away from browser-side SO client #154174

Merged
merged 8 commits into from
Apr 11, 2023

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Mar 31, 2023

Summary

Issue: #154040

Apis added:

  1. Get all the tags with name Security Solution or Create a Security Solution tag if no results found

GET /internal/tags

[
    {
        "id": "ba964280-d211-11ed-890b-153ddf1a08e9",
        "name": "Security Solution",
        "description": "Security Solution auto-generated tag",
        "color": "#2c7b82"
    }
]
  1. Get dashboards with Security Solution tags

GET /internal/dashboards

[
    {
        "type": "dashboard",
        "id": "7de391b0-c1ca-11e7-8995-936807a28b16-ecs",
        "namespaces": [
            "default"
        ],
        "attributes": {
            "description": "Overview of kernel executions",
            "hits": 0,
            "kibanaSavedObjectMeta": {
                "searchSourceJSON": "{\"filter\":[],\"highlightAll\":true,\"query\":{\"language\":\"kuery\",\"query\":\"\"},\"version\":true}"
            },
            "optionsJSON": "{\"darkTheme\":false,\"useMargins\":false}",
            "panelsJSON": "[{\"version\":\"7.3.0\",\"type\":\"visualization\",\"gridData\":{\"h\":12,\"i\":\"1\",\"w\":16,\"x\":16,\"y\":0},\"panelIndex\":\"1\",\"embeddableConfig\":{\"enhancements\":{}},\"panelRefName\":\"panel_1\"},{\"version\":\"7.3.0\",\"type\":\"visualization\",\"gridData\":{\"h\":12,\"i\":\"3\",\"w\":16,\"x\":32,\"y\":0},\"panelIndex\":\"3\",\"embeddableConfig\":{\"enhancements\":{}},\"panelRefName\":\"panel_3\"},{\"version\":\"7.3.0\",\"type\":\"visualization\",\"gridData\":{\"h\":12,\"i\":\"5\",\"w\":16,\"x\":0,\"y\":0},\"panelIndex\":\"5\",\"embeddableConfig\":{\"enhancements\":{}},\"panelRefName\":\"panel_5\"},{\"version\":\"7.3.0\",\"type\":\"search\",\"gridData\":{\"h\":20,\"i\":\"6\",\"w\":48,\"x\":0,\"y\":12},\"panelIndex\":\"6\",\"embeddableConfig\":{\"enhancements\":{}},\"panelRefName\":\"panel_6\"}]",
            "timeRestore": false,
            "title": "[Auditbeat Auditd] Executions ECS",
            "version": 1
        },
        "references": [
            {
                "name": "1:panel_1",
                "id": "20a8e8d0-c1c8-11e7-8995-936807a28b16-ecs",
                "type": "visualization"
            },
            {
                "name": "3:panel_3",
                "id": "f81a6de0-c1c1-11e7-8995-936807a28b16-ecs",
                "type": "visualization"
            },
            {
                "name": "5:panel_5",
                "id": "2efac370-c1ca-11e7-8995-936807a28b16-ecs",
                "type": "visualization"
            },
            {
                "name": "6:panel_6",
                "id": "d382f5b0-c1c6-11e7-8995-936807a28b16-ecs",
                "type": "search"
            },
            {
                "name": "tag-ref-ba964280-d211-11ed-890b-153ddf1a08e9",
                "id": "ba964280-d211-11ed-890b-153ddf1a08e9",
                "type": "tag"
            }
        ],
        "coreMigrationVersion": "8.8.0",
        "typeMigrationVersion": "8.7.0",
        "updated_at": "2023-04-03T11:38:00.902Z",
        "created_at": "2023-04-03T11:20:46.473Z",
        "version": "WzE4NzMsMV0=",
        "score": 0
    }
]

Screenshot 2023-03-31 at 16 10 49

Screenshot 2023-03-31 at 16 09 28

Checklist

Delete any items that are not applicable to this PR.

@angorayc angorayc added Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.8.0 labels Mar 31, 2023
@angorayc angorayc force-pushed the so-client-migration branch from b25f479 to a881f4d Compare March 31, 2023 15:39
@angorayc angorayc marked this pull request as ready for review April 4, 2023 09:13
@angorayc angorayc requested review from a team as code owners April 4, 2023 09:13
@angorayc angorayc requested a review from xcrzx April 4, 2023 09:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@angorayc angorayc added release_note:skip Skip the PR/issue when compiling release notes Feature:Security Dashboards Security solution custom dashboards feature labels Apr 4, 2023
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for doing it Angela 🎉

Copy link
Contributor

@xcrzx xcrzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @angorayc, this PR doesn't seem related to the @elastic/security-detections-response-rules team. However, our review is required due to changes in the security_solution/server/utils directory. I briefly looked through the changes in that folder, and they seem pretty domain-specific. Could you please move them to a folder belonging to the team maintaining that area? This way, code ownership will be aligned, and we won't receive reviews for code we don't support.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3791 3792 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.9MB 15.9MB -356.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 58.0KB 58.0KB +58.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

References to deprecated APIs

id before after diff
securitySolution 415 390 -25

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc angorayc merged commit b064003 into elastic:main Apr 11, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Security Dashboards Security solution custom dashboards feature release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants