Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Migrate away from browser-side SO client #154040

Closed
angorayc opened this issue Mar 30, 2023 · 0 comments
Closed

[SecuritySolution] Migrate away from browser-side SO client #154040

angorayc opened this issue Mar 30, 2023 · 0 comments
Assignees
@angorayc
Labels
Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0

Comments

@angorayc
Copy link
Contributor

angorayc commented Mar 30, 2023 •
edited
Loading

Relevant issue: #149098

Security dashboards has browser-side SO client in used, we need to create server-side apis to migrate away from browser-side SO client for it.

https://github.com/elastic/kibana/blob/main/x-pack/plugins/security_solution/public/common/containers/dashboards/utils.ts#L27

https://github.com/elastic/kibana/blob/main/x-pack/plugins/security_solution/public/common/containers/dashboards/utils.ts#L58

https://github.com/elastic/kibana/blob/b07ef34b9781c8abf3f26552f5ee241abf54e494/x-pack/plugins/security_solution/public/common/containers/dashboards/utils.ts

  1. getTagsByName
  2. getDashboardsByTagIds
@angorayc angorayc added Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.8.0 labels Mar 30, 2023
@angorayc angorayc self-assigned this Mar 30, 2023
@angorayc angorayc mentioned this issue Mar 31, 2023
Merged
2 tasks
angorayc added a commit that referenced this issue Apr 11, 2023
@angorayc
[SecuritySolution] Migrate away from browser-side SO client (#154174)
b064003 
## Summary

Issue: #154040


Apis added: 

1. Get all the tags with name `Security Solution` or Create a Security
Solution tag if no results found
#### GET /internal/tags
```
[
    {
        "id": "ba964280-d211-11ed-890b-153ddf1a08e9",
        "name": "Security Solution",
        "description": "Security Solution auto-generated tag",
        "color": "#2c7b82"
    }
]
```
2. Get dashboards with Security Solution tags
#### GET /internal/dashboards
```
[
    {
        "type": "dashboard",
        "id": "7de391b0-c1ca-11e7-8995-936807a28b16-ecs",
        "namespaces": [
            "default"
        ],
        "attributes": {
            "description": "Overview of kernel executions",
            "hits": 0,
            "kibanaSavedObjectMeta": {
                "searchSourceJSON": "{\"filter\":[],\"highlightAll\":true,\"query\":{\"language\":\"kuery\",\"query\":\"\"},\"version\":true}"
            },
            "optionsJSON": "{\"darkTheme\":false,\"useMargins\":false}",
            "panelsJSON": "[{\"version\":\"7.3.0\",\"type\":\"visualization\",\"gridData\":{\"h\":12,\"i\":\"1\",\"w\":16,\"x\":16,\"y\":0},\"panelIndex\":\"1\",\"embeddableConfig\":{\"enhancements\":{}},\"panelRefName\":\"panel_1\"},{\"version\":\"7.3.0\",\"type\":\"visualization\",\"gridData\":{\"h\":12,\"i\":\"3\",\"w\":16,\"x\":32,\"y\":0},\"panelIndex\":\"3\",\"embeddableConfig\":{\"enhancements\":{}},\"panelRefName\":\"panel_3\"},{\"version\":\"7.3.0\",\"type\":\"visualization\",\"gridData\":{\"h\":12,\"i\":\"5\",\"w\":16,\"x\":0,\"y\":0},\"panelIndex\":\"5\",\"embeddableConfig\":{\"enhancements\":{}},\"panelRefName\":\"panel_5\"},{\"version\":\"7.3.0\",\"type\":\"search\",\"gridData\":{\"h\":20,\"i\":\"6\",\"w\":48,\"x\":0,\"y\":12},\"panelIndex\":\"6\",\"embeddableConfig\":{\"enhancements\":{}},\"panelRefName\":\"panel_6\"}]",
            "timeRestore": false,
            "title": "[Auditbeat Auditd] Executions ECS",
            "version": 1
        },
        "references": [
            {
                "name": "1:panel_1",
                "id": "20a8e8d0-c1c8-11e7-8995-936807a28b16-ecs",
                "type": "visualization"
            },
            {
                "name": "3:panel_3",
                "id": "f81a6de0-c1c1-11e7-8995-936807a28b16-ecs",
                "type": "visualization"
            },
            {
                "name": "5:panel_5",
                "id": "2efac370-c1ca-11e7-8995-936807a28b16-ecs",
                "type": "visualization"
            },
            {
                "name": "6:panel_6",
                "id": "d382f5b0-c1c6-11e7-8995-936807a28b16-ecs",
                "type": "search"
            },
            {
                "name": "tag-ref-ba964280-d211-11ed-890b-153ddf1a08e9",
                "id": "ba964280-d211-11ed-890b-153ddf1a08e9",
                "type": "tag"
            }
        ],
        "coreMigrationVersion": "8.8.0",
        "typeMigrationVersion": "8.7.0",
        "updated_at": "2023-04-03T11:38:00.902Z",
        "created_at": "2023-04-03T11:20:46.473Z",
        "version": "WzE4NzMsMV0=",
        "score": 0
    }
]
```

<img width="2557" alt="Screenshot 2023-03-31 at 16 10 49"
src="https://user-images.githubusercontent.com/6295984/229166859-6d765332-aa04-4da2-acde-456b04682914.png">


<img width="2547" alt="Screenshot 2023-03-31 at 16 09 28"
src="https://user-images.githubusercontent.com/6295984/229166834-0b61c1cd-53a8-4c5c-892e-94f19deb95f2.png">


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
@semd semd mentioned this issue Apr 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angorayc angorayc

Labels
Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@angorayc