Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules: cleanup saved objects mappings #153147

Closed
wants to merge 10 commits into from
Closed

rules: cleanup saved objects mappings #153147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a5be680
rules: cleanup saved objects mappings
TinaHeiligers Mar 11, 2023
0778d26
actions: cleanup mappings
TinaHeiligers Mar 11, 2023
eca7f5c
Updates snapshot
TinaHeiligers Mar 15, 2023
00fae82
Merge branch 'main' into alerting-cleanup-saved-objects-mappings
TinaHeiligers Mar 15, 2023
2202dd3
Merge branch 'main' into alerting-cleanup-saved-objects-mappings
TinaHeiligers Mar 21, 2023
dde85b6
Updates core integration test
TinaHeiligers Mar 23, 2023
fa6294a
Merge branch 'main' into alerting-cleanup-saved-objects-mappings
kibanamachine Mar 23, 2023
14c2684
Merge branch 'main' into alerting-cleanup-saved-objects-mappings
kibanamachine Mar 26, 2023
13cb2ca
deletes commented out mappings
TinaHeiligers Mar 26, 2023
3b318f7
Merge branch 'main' into alerting-cleanup-saved-objects-mappings
kibanamachine Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...e/server/integration_tests/saved_objects/migrations/group2/check_registered_types.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ describe('checking migration metadata changes on all registered SO types', () =>
Object {
"action": "6cfc277ed3211639e37546ac625f4a68f2494215",
"action_task_params": "5f419caba96dd8c77d0f94013e71d43890e3d5d6",
"alert": "1e4cd6941f1eb39c729c646e91fbfb9700de84b9",
"alert": "cd2ec6f540cbb9305452e1582ccff8ad00917903",
"api_key_pending_invalidation": "16e7bcf8e78764102d7f525542d5b616809a21ee",
"apm-indices": "d19dd7fb51f2d2cbc1f8769481721e0953f9a6d2",
"apm-server-schema": "1d42f17eff9ec6c16d3a9324d9539e2d123d0a9a",
Expand Down Expand Up @@ -123,7 +123,7 @@ describe('checking migration metadata changes on all registered SO types', () =>
"osquery-pack-asset": "18e08979d46ee7e5538f54c080aec4d8c58516ca",
"osquery-saved-query": "f5e4e303f65c7607248ea8b2672f1ee30e4fb15e",
"query": "ec6000b775f06f81470df42d23f7a88cb31d64ba",
"rules-settings": "9854495c3b54b16a6625fb250c35e5504da72266",
"rules-settings": "2b8b610c10eccd3d5577a1bd817f3e1103abc366",
"sample-data-telemetry": "c38daf1a49ed24f2a4fb091e6e1e833fccf19935",
"search": "01bc42d635e9ea0588741c4c7a2bbd3feb3ac5dc",
"search-session": "58a44d14ec991739166b2ec28d718001ab0f4b28",
Expand Down
16 changes: 2 additions & 14 deletions x-pack/plugins/alerting/server/saved_objects/mappings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,20 +58,8 @@ export const alertMappings: SavedObjectsTypeMappingDefinition = {
properties: {},
},
frequency: {
properties: {
summary: {
index: false,
type: 'boolean',
},
notifyWhen: {
index: false,
type: 'keyword',
},
throttle: {
index: false,
type: 'keyword',
},
},
dynamic: false,
properties: {},
},
},
},
Expand Down
32 changes: 2 additions & 30 deletions x-pack/plugins/alerting/server/saved_objects/rules_settings_mappings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,36 +10,8 @@ import { SavedObjectsTypeMappingDefinition } from '@kbn/core/server';
export const rulesSettingsMappings: SavedObjectsTypeMappingDefinition = {
properties: {
flapping: {
properties: {
enabled: {
type: 'boolean',
index: false,
},
lookBackWindow: {
type: 'long',
index: false,
},
statusChangeThreshold: {
type: 'long',
index: false,
},
createdBy: {
type: 'keyword',
index: false,
},
updatedBy: {
type: 'keyword',
index: false,
},
createdAt: {
type: 'date',
index: false,
},
updatedAt: {
type: 'date',
index: false,
},
},
dynamic: false,
properties: {},
},
},
};
2 changes: 1 addition & 1 deletion x-pack/plugins/apm/server/saved_objects/apm_server_settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const apmServerSettings: SavedObjectsType = {
properties: {
schemaJson: {
type: 'text',
index: false,
index: false, // referenced directly in `createCloudApmPackgePolicy`
},
},
},
Expand Down