Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules: cleanup saved objects mappings #153147

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Mar 11, 2023

Summary

Related to #149102

Subset of the global cleanup attempt in #153070

Dry run for cleaning up rules mappings

Checklist

@TinaHeiligers TinaHeiligers added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types v8.8.0 labels Mar 11, 2023
@TinaHeiligers
Copy link
Contributor Author

@elastic/response-ops f CI goes green, we can use this PR to clean up the mappings.
If not, it means there's a direct reference to the fields. Could you please review these fields and update the mapping accordingly?

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers marked this pull request as ready for review March 27, 2023 16:16
@TinaHeiligers TinaHeiligers requested review from a team as code owners March 27, 2023 16:16
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/saved-objects-service.html#_mappings

id before after diff
alert 101 97 -4
rules-settings 9 - -9
total -13
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Mar 28, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes LGTM

@pmuellr
Copy link
Member

pmuellr commented Mar 28, 2023

note, there are also alerting SO mapping cleanups in PR #152857 cc: @XavierM

Guessing we'll want the #152857 version for alerting, and not this in this PR.

@TinaHeiligers
Copy link
Contributor Author

TinaHeiligers commented Mar 29, 2023

Guessing we'll want the #152857 version for alerting, and not this in this PR.

@pmuellr are you talking about the changes to the mappings I made here in the alerting plugin? Should I revert those?

@pmuellr
Copy link
Member

pmuellr commented Mar 29, 2023

are you talking about the changes to the mappings I made here in the alerting plugin? Should I revert those?

I honestly don't know, but @XavierM will. I just happened to notice this PR with SO mapping changes to alerting SO's, and knew that Xavier has also been doing some of this ...

@TinaHeiligers
Copy link
Contributor Author

Xavier has also been doing some of this

@XavierM Please let me know if you'd prefer to handle the mapping changes for alerting or if you'd like me to merge this PR to help you out.

@TinaHeiligers
Copy link
Contributor Author

The mapping changes for alerting are to be handled in #152857 and the only change here to the mappings for apm is a code comment. As such, this PR is not needed.

@TinaHeiligers TinaHeiligers deleted the alerting-cleanup-saved-objects-mappings branch March 31, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants