-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SecuritySolution] Setup dashboard view page #153040
Conversation
91a75e9
to
a745c30
Compare
e14a558
to
7e77cdc
Compare
to: nextDateRange.dateRangeTo, | ||
}, | ||
}); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this because the time range of the Visualization wouldn't update after brushing on a time-based histogram / area chart.
brushing_on_chart.mov
After:
Screen.Recording.2023-03-27.at.11.35.47.mov
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
@angorayc I don't understand why onBrush doesn't work tbh. It works on all visualizations on a dashboard without adding an extra method on unified search. Are you using the onBrushEnd method of Lens embeddable? I think it makes sense first to understand why it doesn't work cc @dej611 if you have any input here. |
Agree with @stratoula that it is better to find out what's going wrong here rather than adding a new method. |
cc @ThomThomson for his input here too. |
I think the reason that brushing doesn't work because Security Solution doesn't share the same url param structure as others, we do not put time range under _g, and we do not use I was thinking of calling |
@angorayc yes I think using the onQueryChange makes more sense to me, do you want to give it a try? |
@stratoula , yup, changed |
I see, no I suggest to try understand why onBrush doesnt work for embedded dashboards. Let's see if Marco and Devon find anything otherwise I have to check the code. |
19d1691
to
e2fe716
Compare
Here's a link to the demo page: https://kibana-pr-153040.kb.us-west2.gcp.elastic-cloud.com:9243/app/security/dashboards/6294c960-ce35-11ed-b8ca-51636b04063c?sourcerer=(default:(id:security-solution-default,selectedPatterns:!(%27auditbeat-*%27,%27logs-*%27))) https://p.elstc.co/paste/pOFVo-fV#Zgp3hnsnijsDHbki4y9Cy5F+apet-hYEcedpDzsc+f7 The edit button takes user to the dashboards app at the moment. Eventually we should be able to allow users to edit in SecuritySolution’s app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanx Angela, unified search changes LGTM!
Co-authored-by: Stratoula Kalafateli <[email protected]>
…-ref HEAD~1..HEAD --fix'
fd2366b
to
7c70a98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for addressing the comments @angorayc
This Dashboard view is super powerful 🔥🔥
LGTM! 🚀
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @angorayc |
## Summary issue: #152955 follow up of #153040 These changes make the dashboard name to be displayed in the page title, as requested by @paulewing ## Screenshots ![example](https://user-images.githubusercontent.com/17747913/233359294-a3055aa5-5e2e-4412-93a6-bffd54d93840.png) ![not_found](https://user-images.githubusercontent.com/17747913/233359333-b0175225-99d1-41f3-b3e4-aed630531786.png)
Summary
#152955
Demo link: https://kibana-pr-154806.kb.us-west2.gcp.elastic-cloud.com:9243/
https://p.elstc.co/paste/vPoSt7eC#txCuL6KJWRCPRJ0ae4minlT7IgGBJ5F8MTloWIOVQcw
This create a single dashboard view under Security Solution:
/app/security/dashboards/:dashboardId
Dashboard not found:
Dashboard rendered:
Interact with filters and query:
Screen.Recording.2023-03-23.at.13.47.06.mov
Interact with
Open in Lens
andInvestigate in timeline
Screen.Recording.2023-03-28.at.12.07.32.mov
Steps to verify:
/app/dashboards#/list
, save it and copy the dashboard saved object id from url./app/security/dashboards/:dashboardId
Known issues:
#154842
#154843
Checklist
Delete any items that are not applicable to this PR.