Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests - stabilize and re-enable export jobs tests #152334

Merged
merged 10 commits into from
May 3, 2023
Merged

[ML] Functional tests - stabilize and re-enable export jobs tests #152334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
87261f1
[ML] Functional tests - stabilize and re-enable export jobs tests
pheyos Feb 28, 2023
90b0782
Revert increased timeout, add better assertion message
pheyos Feb 28, 2023
2e2d7b7
Use the correct way to run browser in headless mode
pheyos Feb 28, 2023
4a448ac
Unskip download CSV tests
pheyos Feb 28, 2023
2f1e945
Merge branch 'main' into reenable_export_jobs_tests
pheyos Mar 1, 2023
bcdb01d
Merge branch 'main' into reenable_export_jobs_tests
pheyos Mar 24, 2023
45efba3
Revert "Use the correct way to run browser in headless mode"
pheyos Mar 24, 2023
4d78704
Merge branch 'main' into reenable_export_jobs_tests
pheyos Mar 27, 2023
6723fbd
Merge branch 'main' into reenable_export_jobs_tests
pheyos Mar 28, 2023
0d2058e
Merge branch 'main' into reenable_export_jobs_tests
pheyos Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions x-pack/test/functional/apps/dashboard/group3/reporting/download_csv.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await testSubjects.existOrFail('csvDownloadStarted'); // validate toast panel
};

// Failing: See https://github.com/elastic/kibana/issues/150561
// Failing: See https://github.com/elastic/kibana/issues/150562
// Failing: See https://github.com/elastic/kibana/issues/148314
// Failing: See https://github.com/elastic/kibana/issues/150563
// Failing: See https://github.com/elastic/kibana/issues/150561
describe.skip('Download CSV', () => {
describe('Download CSV', () => {
before('initialize tests', async () => {
log.debug('ReportingPage:initTests');
await browser.setWindowSize(1600, 850);
Expand Down
5 changes: 3 additions & 2 deletions x-pack/test/functional/apps/ml/stack_management_jobs/export_jobs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,9 @@ export default function ({ getService }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
const ml = getService('ml');

// Failing: See https://github.com/elastic/kibana/issues/150557
describe.skip('export jobs', function () {
describe('export jobs', function () {
this.tags(['ml']);

before(async () => {
await ml.api.cleanMlIndices();
await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/ml/farequote');
Expand Down Expand Up @@ -282,6 +282,7 @@ export default function ({ getService }: FtrProviderContext) {
await ml.navigation.navigateToStackManagement();
await ml.navigation.navigateToStackManagementJobsListPage();
});

after(async () => {
await ml.api.cleanMlIndices();
ml.stackManagementJobs.deleteExportedFiles([
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/functional/services/ml/stack_management_jobs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ export function MachineLearningStackManagementJobsProvider({

async getDownload(filePath: string) {
return retry.tryForTime(5000, async () => {
expect(fs.existsSync(filePath)).to.be(true);
expect(fs.existsSync(filePath)).to.eql(true, `File path ${filePath} should exist`);
return fs.readFileSync(filePath).toString();
});
},
Expand Down