[ML] Functional tests - stabilize and re-enable export jobs tests #152334
Conversation
|
Checking test stability in a flaky test runner job ... still failed ❌ |
|
Local tests showed that this was an issue with the way how we invoked Chrome's headless mode. |
|
Checking test stability again (including the unskipped CSV download tests) in a flaky test runner job ... download tests passed, but other tests started failing ❌ |
|
It turned out to be an issue on the Chromedriver side, which is already fixed for version 111. With that, we decided to wait a few more days for version 111 of Chrome and Chromedriver to be out rather than rushing the new headless mode in (which seems to slightly change some behavior and needs more investigation). |
|
It looks like Chrome version 111 didn't actually fix the issue for us. |
|
The new browser headless mode has been introduced with #153828, which should hopefully unblock this PR. |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @pheyos |
|
Checking test stability in a flaky test runner job ... no failure in 50 runs ✔️ |
pheyos
added
:ml
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
Good point @peteharverson. That was a left-over from the first iteration. But it turned out that we didn't need any further code changes after switching to the new headless browser mode which was done in a separate PR. I've updated the description. |
…astic#152334) This PR re-enables the export job tests and the reporting download tests after the underlying issues has been fixed by switching to the new headless browser mode. (cherry picked from commit a90f4c2)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…ts (#152334) (#156480) # Backport This will backport the following commits from `main` to `8.8`: - [[ML] Functional tests - stabilize and re-enable export jobs tests (#152334)](#152334) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Oskamp","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-03T08:19:44Z","message":"[ML] Functional tests - stabilize and re-enable export jobs tests (#152334)\n\nThis PR re-enables the export job tests and the reporting download tests\r\nafter the underlying issues has been fixed by switching to the new\r\nheadless browser mode.","sha":"a90f4c24dac8d6d23105e1a5119c36634aa27f42","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","backport:prev-minor","v8.8.0","v8.9.0"],"number":152334,"url":"https://github.com/elastic/kibana/pull/152334","mergeCommit":{"message":"[ML] Functional tests - stabilize and re-enable export jobs tests (#152334)\n\nThis PR re-enables the export job tests and the reporting download tests\r\nafter the underlying issues has been fixed by switching to the new\r\nheadless browser mode.","sha":"a90f4c24dac8d6d23105e1a5119c36634aa27f42"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152334","number":152334,"mergeCommit":{"message":"[ML] Functional tests - stabilize and re-enable export jobs tests (#152334)\n\nThis PR re-enables the export job tests and the reporting download tests\r\nafter the underlying issues has been fixed by switching to the new\r\nheadless browser mode.","sha":"a90f4c24dac8d6d23105e1a5119c36634aa27f42"}}]}] BACKPORT--> Co-authored-by: Robert Oskamp <[email protected]>
Summary
This PR re-enables the export job tests and the reporting download tests after the underlying issues has been fixed by switching to the new headless browser mode.
Closes #150756
Closes #150558
Closes #150557
Closes #150561
Closes #150562
Closes #148314
Closes #150563
Closes #150561