-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[poc][serverless] Unified Navigation #152172
Closed
clintandrewhall
wants to merge
76
commits into
elastic:main
from
clintandrewhall:serverless/poc/navigation
Closed
[poc][serverless] Unified Navigation #152172
clintandrewhall
wants to merge
76
commits into
elastic:main
from
clintandrewhall:serverless/poc/navigation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintandrewhall
force-pushed
the
serverless/poc/navigation
branch
from
February 27, 2023 05:02
5588e5d
to
5cdb373
Compare
clintandrewhall
force-pushed
the
serverless/poc/navigation
branch
4 times, most recently
from
February 27, 2023 08:14
00ba366
to
e0e35ca
Compare
clintandrewhall
force-pushed
the
serverless/poc/navigation
branch
4 times, most recently
from
February 27, 2023 18:12
815e429
to
69b62cc
Compare
clintandrewhall
force-pushed
the
serverless/poc/navigation
branch
from
February 28, 2023 03:03
69b62cc
to
ec92b8a
Compare
clintandrewhall
force-pushed
the
serverless/poc/navigation
branch
from
March 13, 2023 19:16
e43e5db
to
a1aa9cd
Compare
[PoC][Security Solution] Serverless navigation
…t/disable-plugins [Serverless] Disable Management team plugins
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
miscellaneous assets size
History
To update your PR or re-run it, just comment with: cc @tsullivan @rudolf @pgayvallet @lukeelmers @thomasneirynck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing in favor of #153274
This PR sources changes from my fork of Kibana, which doesn't allow PRs opened against it to run CI and other tasks. I'm closing this PR in favor of #153274, which consolidates the changes.
Thank you to all who contributed here!
cc: @TattdCodeMonkey @semd @yuliacech @tsullivan
Summary
This POC is an application of the principles I've outlined elsewhere, using "unified navigation" as a functional example, where:
core
changes are established as functional changes, rather than "serverless" changes;chromeStyle
,setSolutionNavigation
isSidebarEnabled
serverless
plugin provides APIs related to Serverless functional implementations;setServerlessNavigation
serverless-[project space]
plugins usecore
,serverless
and other plugins to create their Kibana configuration.By simply enabling the
serverless
andserverless-*
plugin, we can create a project.Notes
serverless
plugin simply provides an alias tocore
to populate the navigation area. While anemic in this POC, it is assumed there would be much more business/functional logic here, and that we'd expectserverless-*
plugins to avoid usingcore
APIs directly, (beyond the obvious usages, e.g.basePath
, etc)Testing
Run
yarn serverless-oblt
oryarn serverless-security
locally.Next Steps
The immediate next step is to coalesce the different navigation requirements into a @elastic/appex-sharedux component downstream teams could consume to create a unified experience, (@tsullivan) Look to
serverless_*/public/plugin.tsx
for calls to theserverless
plugin to render navigation.We've had conversations with @elastic/security-solution and @elastic/observability-ui, and we can use this POC as a "jumping-off point" to iterate on navigation schemes. We can also continue to use this to validate the UX technical approach.