-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PoC][Security Solution] Serverless navigation #30
[PoC][Security Solution] Serverless navigation #30
Conversation
…l/kibana into serverless/poc/navigation
This is awesome. @tsullivan, @sixstringcode, we should look at what was done here for elastic#152510. @semd I'm not sure if we'll merge this directly to the PoC, or if we'll include it as part of the navigation component package that @tsullivan is working on. Let's discuss on Monday. At the very least, we can use the package as a Thank you for this, it's incredibly important context for how we'll unify nav in projects. |
…om/semd/kibana into security_serverless_navigation_poc
This looks so polished, thanks for jumping on this so quick @semd |
Summary
This POC is an implementation on top of the @clintandrewhall PoC, that integrates the current Security "grouped" navigation in the global chrome navigation for serverless.
SolutionGroupedNavigation
migrated to shared-ux package component asSideNavigation
.navItems$
on-start observable exposed.Limitations
mount
, we can expose the store to be consumed from the serverless_security plugin, even if it may not exist when we are on a non-security page. However, this is non-critical since all pages add their specific urlState to the URL (using replace) when they load, so links can still be shared after navigation. We only lose urlState information when right-clicking and using "copy link address" in the navigation links directly.Testing
Run
yarn serverless-security
locally.Screenshots