[Dashboard] fix searchSessionId not updated when pinned filter changes #151390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
Feature:Dashboard
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
nreese
added
loe:small
lukasolson
approved these changes
Feb 16, 2023
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
ThomThomson
approved these changes
Feb 21, 2023
| expect(await getShouldRefresh.bind(dashboardContainerMock)(lastInput, input)).toBe(true); | ||
| }); | ||
|
|
||
| test('should return false when disabled filters change', async () => { |
| return Object.keys(inputChanges).length > 0; | ||
| } | ||
|
|
||
| async function getInputChanges( |
There was a problem hiding this comment.
Good call moving this to a shared function.
kibanamachine
pushed a commit
that referenced
this pull request
Feb 21, 2023
#151390) Fixes #151219 and #151224 PR separates shouldRefresh logic from unsavedChanges logic to account for difference in filter check. shouldRefresh filter check: * includes pinned filters * excludes disabled filters * excludes $state so pinning/unpinning a filter does not cause a refresh. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit cd910be)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
kibanamachine
added a commit
that referenced
this pull request
Feb 21, 2023
…changes (#151390) (#151742) # Backport This will backport the following commits from `main` to `8.7`: - [[Dashboard] fix searchSessionId not updated when pinned filter changes (#151390)](#151390) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-21T16:31:06Z","message":"[Dashboard] fix searchSessionId not updated when pinned filter changes (#151390)\n\nFixes #151219 and\r\nhttps://github.com//issues/151224\r\n\r\nPR separates shouldRefresh logic from unsavedChanges logic to account\r\nfor difference in filter check.\r\n\r\nshouldRefresh filter check:\r\n* includes pinned filters\r\n* excludes disabled filters\r\n* excludes $state so pinning/unpinning a filter does not cause a\r\nrefresh.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"cd910bee1cb062111e094c2744f153010e6b2e2c","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Dashboard","release_note:fix","Team:Presentation","loe:hours","impact:medium","auto-backport","v8.7.0","v8.8.0"],"number":151390,"url":"https://github.com/elastic/kibana/pull/151390","mergeCommit":{"message":"[Dashboard] fix searchSessionId not updated when pinned filter changes (#151390)\n\nFixes #151219 and\r\nhttps://github.com//issues/151224\r\n\r\nPR separates shouldRefresh logic from unsavedChanges logic to account\r\nfor difference in filter check.\r\n\r\nshouldRefresh filter check:\r\n* includes pinned filters\r\n* excludes disabled filters\r\n* excludes $state so pinning/unpinning a filter does not cause a\r\nrefresh.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"cd910bee1cb062111e094c2744f153010e6b2e2c"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151390","number":151390,"mergeCommit":{"message":"[Dashboard] fix searchSessionId not updated when pinned filter changes (#151390)\n\nFixes #151219 and\r\nhttps://github.com//issues/151224\r\n\r\nPR separates shouldRefresh logic from unsavedChanges logic to account\r\nfor difference in filter check.\r\n\r\nshouldRefresh filter check:\r\n* includes pinned filters\r\n* excludes disabled filters\r\n* excludes $state so pinning/unpinning a filter does not cause a\r\nrefresh.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"cd910bee1cb062111e094c2744f153010e6b2e2c"}}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151219 and #151224
PR separates shouldRefresh logic from unsavedChanges logic to account for difference in filter check.
shouldRefresh filter check: