Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] searchSessionId updated when disabled filter changes #151224

Closed
nreese opened this issue Feb 14, 2023 · 3 comments
Closed

[Dashboard] searchSessionId updated when disabled filter changes #151224

nreese opened this issue Feb 14, 2023 · 3 comments
Assignees
@nreese
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nreese
Copy link
Contributor

nreese commented Feb 14, 2023

Steps to view problem

  1. install web logs sample data set
  2. create dashboard with visualization panel
  3. add filter pill and disable it
  4. open browser new work tab.
  5. edit filter by toggling exclude
  6. notice how each action results in bsearch network request, even though the results will be the same

searchSessionId should not change when disabled filter is updated
@nreese nreese added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Feb 14, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@kibanamachine kibanamachine added the loe:needs-research This issue requires some research before it can be worked on or estimated label Feb 14, 2023
@nreese nreese mentioned this issue Feb 14, 2023
Closed
@nreese
Copy link
Contributor Author

nreese commented Feb 14, 2023

blocking #151223

@nreese nreese self-assigned this Feb 15, 2023
@nreese nreese mentioned this issue Feb 15, 2023
Merged
nreese added a commit that referenced this issue Feb 21, 2023
@nreese @kibanamachine
[Dashboard] fix searchSessionId not updated when pinned filter changes (
cd910be 
#151390)

Fixes #151219 and
#151224

PR separates shouldRefresh logic from unsavedChanges logic to account
for difference in filter check.

shouldRefresh filter check:
* includes pinned filters
* excludes disabled filters
* excludes $state so pinning/unpinning a filter does not cause a
refresh.

---------

Co-authored-by: kibanamachine <[email protected]>
@nreese
Copy link
Contributor Author

nreese commented Feb 21, 2023

closed by #151390

@nreese nreese closed this as completed Feb 21, 2023
kibanamachine pushed a commit that referenced this issue Feb 21, 2023
@nreese
[Dashboard] fix searchSessionId not updated when pinned filter changes (
cd31cde 
#151390)

Fixes #151219 and
#151224

PR separates shouldRefresh logic from unsavedChanges logic to account
for difference in filter check.

shouldRefresh filter check:
* includes pinned filters
* excludes disabled filters
* excludes $state so pinning/unpinning a filter does not cause a
refresh.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit cd910be)
kibanamachine added a commit that referenced this issue Feb 21, 2023
@kibanamachine @nreese
[8.7] [Dashboard] fix searchSessionId not updated when pinned filter …
748dfcb 
…changes (#151390) (#151742)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Dashboard] fix searchSessionId not updated when pinned filter
changes (#151390)](#151390)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-21T16:31:06Z","message":"[Dashboard]
fix searchSessionId not updated when pinned filter changes
(#151390)\n\nFixes #151219
and\r\nhttps://github.com//issues/151224\r\n\r\nPR
separates shouldRefresh logic from unsavedChanges logic to
account\r\nfor difference in filter check.\r\n\r\nshouldRefresh filter
check:\r\n* includes pinned filters\r\n* excludes disabled filters\r\n*
excludes $state so pinning/unpinning a filter does not cause
a\r\nrefresh.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"cd910bee1cb062111e094c2744f153010e6b2e2c","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Dashboard","release_note:fix","Team:Presentation","loe:hours","impact:medium","auto-backport","v8.7.0","v8.8.0"],"number":151390,"url":"https://github.com/elastic/kibana/pull/151390","mergeCommit":{"message":"[Dashboard]
fix searchSessionId not updated when pinned filter changes
(#151390)\n\nFixes #151219
and\r\nhttps://github.com//issues/151224\r\n\r\nPR
separates shouldRefresh logic from unsavedChanges logic to
account\r\nfor difference in filter check.\r\n\r\nshouldRefresh filter
check:\r\n* includes pinned filters\r\n* excludes disabled filters\r\n*
excludes $state so pinning/unpinning a filter does not cause
a\r\nrefresh.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"cd910bee1cb062111e094c2744f153010e6b2e2c"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151390","number":151390,"mergeCommit":{"message":"[Dashboard]
fix searchSessionId not updated when pinned filter changes
(#151390)\n\nFixes #151219
and\r\nhttps://github.com//issues/151224\r\n\r\nPR
separates shouldRefresh logic from unsavedChanges logic to
account\r\nfor difference in filter check.\r\n\r\nshouldRefresh filter
check:\r\n* includes pinned filters\r\n* excludes disabled filters\r\n*
excludes $state so pinning/unpinning a filter does not cause
a\r\nrefresh.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"cd910bee1cb062111e094c2744f153010e6b2e2c"}}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nreese @elasticmachine @kibanamachine