Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps][ML] fix Typical to actual connector lines in AnomalyLayer have dot halfway #149270

Merged
merged 3 commits into from
Jan 23, 2023

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jan 19, 2023

Fixes #148694

PR updates AnomalySource.isMvt to return false since the source is not a vector tile source. See #148694 (comment) for details

@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:ML Team label for ML (also use :ml) v8.7.0 release_note:fix backport:skip This commit does not require backporting labels Jan 19, 2023
@nreese nreese marked this pull request as ready for review January 20, 2023 00:17
@nreese nreese requested a review from a team as a code owner January 20, 2023 00:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing any points showing up in the map now for anomaly detection layer due to this getTileUrl is not a function error. Looks like that's due to it being a different type of layer. Does something else need to to be added to the map config to handle this?
image

@nreese
Copy link
Contributor Author

nreese commented Jan 20, 2023

I'm not seeing any points showing up in the map now for anomaly detection layer due to this getTileUrl is not a function error. Looks like that's due to it being a different type of layer. Does something else need to to be added to the map config to handle this?

Thanks for pointing this out. After taking a second look at AnomalySource implementation, the layer should stay GEOJSON_VECTOR. Instead, AnomalySource.isMvt should return false, since the source is not a vector tile source. I have pushed these changes

@nreese
Copy link
Contributor Author

nreese commented Jan 23, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@nreese nreese merged commit d3f71be into elastic:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:fix Team:ML Team label for ML (also use :ml) Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps][ML] Typical to actual connector lines in AnomalyLayer have dot halfway
5 participants