Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps][ML] Typical to actual connector lines in AnomalyLayer have dot halfway #148694

Closed
thomasneirynck opened this issue Jan 10, 2023 · 4 comments · Fixed by #149270
Closed

[Maps][ML] Typical to actual connector lines in AnomalyLayer have dot halfway #148694

thomasneirynck opened this issue Jan 10, 2023 · 4 comments · Fixed by #149270
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. :ml Team:ML Team label for ML (also use :ml) Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.7.0

Comments

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Jan 10, 2023

Kibana version:

main/8.7

Describe the bug:

The typical to actual line in the AnomalyLayer have a dot halfway.

image

Steps to reproduce:

  1. create lon-lat anomaly detection job in ML
  2. in Maps, add anomaly-layer for that type.
  3. Open layer-settings. Change type to typical to actual in the Anomalies section.

Expected behavior:

The dot is not there.

Any additional context:

This was raised first here #147797 (comment)

This is likely a regression. The regression may not have been caused because of any changes in the AnomalySource. Instead, changes in Maps may have revealed some incomplete implementation in AnomalySource (?).

e.g. the placement of that point is where the label should be placed. So the point-location for the dot is likely created by Maps, not by ML.

@thomasneirynck thomasneirynck added the bug Fixes for quality problems that affect the customer experience label Jan 10, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 10, 2023
@thomasneirynck thomasneirynck changed the title [Maps][ML] Typical to actual in AnomalyLayer connector lines have dot halfwat [Maps][ML] Typical to actual connector lines in AnomalyLayer have dot halfway Jan 11, 2023
@thomasneirynck thomasneirynck added the Team:ML Team label for ML (also use :ml) label Jan 11, 2023
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 11, 2023
@thomasneirynck thomasneirynck added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Jan 11, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@nreese
Copy link
Contributor

nreese commented Jan 19, 2023

I have isolated the problem. The problem occurs because the layer is of type GEOJSON_VECTOR but AnomalySource implements IVectorSource.isMvt which returns true. The mismatch between geojson layer and mvt source is causing the problems.

Short term fix, ML layers with AnomalySource should use layer type MVT_VECTOR.

Longer term, Maps should not store and use state information in 2 locations. GEOJSON_VECTOR and MVT_VECTOR should be consolidated into a single layer type VECTOR and then layer implementation should be selected based on vectorSource.isMvt method.

@nreese nreese added Feature:Maps impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jan 19, 2023
@nreese
Copy link
Contributor

nreese commented Jan 19, 2023

Opened #149270 for short term fix

@nreese nreese self-assigned this Jan 19, 2023
nreese added a commit that referenced this issue Jan 23, 2023
… dot halfway (#149270)

Fixes #148694

PR updates `AnomalySource.isMvt` to return false since the source is not
a vector tile source. See
#148694 (comment)
for details

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. :ml Team:ML Team label for ML (also use :ml) Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.7.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants