[ML] Transforms: Fix transforms JSON display #147996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
bug
|
Pinging @elastic/ml-ui (:ml) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 9, 2023
Fixing a typo in the code from when the JSON editor was [converted](elastic#108310) from using `EuiCodeEditor` **Before**  **After**  (cherry picked from commit ba06f68)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 9, 2023
# Backport This will backport the following commits from `main` to `8.6`: - [[ML] Transforms: Fix transforms JSON display (#147996)](#147996) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-01-09T14:58:56Z","message":"[ML] Transforms: Fix transforms JSON display (#147996)\n\nFixing a typo in the code from when the JSON editor was\r\n[converted](#108310) from using\r\n`EuiCodeEditor`\r\n\r\n**Before**\r\n\r\n\r\n\r\n**After**\r\n\r\n","sha":"ba06f687522fed393036ff01d9230f341e37d710","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix",":ml","Feature:Transforms","v8.6.0","v8.7.0"],"number":147996,"url":"https://github.com/elastic/kibana/pull/147996","mergeCommit":{"message":"[ML] Transforms: Fix transforms JSON display (#147996)\n\nFixing a typo in the code from when the JSON editor was\r\n[converted](#108310) from using\r\n`EuiCodeEditor`\r\n\r\n**Before**\r\n\r\n\r\n\r\n**After**\r\n\r\n","sha":"ba06f687522fed393036ff01d9230f341e37d710"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/147996","number":147996,"mergeCommit":{"message":"[ML] Transforms: Fix transforms JSON display (#147996)\n\nFixing a typo in the code from when the JSON editor was\r\n[converted](#108310) from using\r\n`EuiCodeEditor`\r\n\r\n**Before**\r\n\r\n\r\n\r\n**After**\r\n\r\n","sha":"ba06f687522fed393036ff01d9230f341e37d710"}}]}] BACKPORT--> Co-authored-by: James Gowdy <[email protected]>
|
The backport was not included on |
","sha":"ba06f687522fed393036ff01d9230f341e37d710","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix",":ml","Feature:Transforms","v8.6.0","v8.7.0"],"number":147996,"url":"https://github.com/elastic/kibana/pull/147996","mergeCommit":{"message":"[ML]](https://user-images.githubusercontent.com/22172091/209140230-fcb3fff5-0040-487a-bffc-581a8fe2f4e4.png)\r\n\r\n**After**\r\n\r\n","sha":"ba06f687522fed393036ff01d9230f341e37d710","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix",":ml","Feature:Transforms","v8.6.0","v8.7.0"],"number":147996,"url":"https://github.com/elastic/kibana/pull/147996","mergeCommit":{"message":"[ML]){kind=link}
","sha":"ba06f687522fed393036ff01d9230f341e37d710"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/147996","number":147996,"mergeCommit":{"message":"[ML]](https://user-images.githubusercontent.com/22172091/209140230-fcb3fff5-0040-487a-bffc-581a8fe2f4e4.png)\r\n\r\n**After**\r\n\r\n","sha":"ba06f687522fed393036ff01d9230f341e37d710"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/147996","number":147996,"mergeCommit":{"message":"[ML]){kind=link}
","sha":"ba06f687522fed393036ff01d9230f341e37d710](https://user-images.githubusercontent.com/22172091/209140230-fcb3fff5-0040-487a-bffc-581a8fe2f4e4.png)\r\n\r\n**After**\r\n\r\n","sha":"ba06f687522fed393036ff01d9230f341e37d710){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a typo in the code from when the JSON editor was converted from using
EuiCodeEditorBefore
After
