Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Transforms: replace deprecated EuiCodeEditor #108310

Merged
merged 5 commits into from
Aug 18, 2021
Merged

[ML] Transforms: replace deprecated EuiCodeEditor #108310

merged 5 commits into from
Aug 18, 2021

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Aug 12, 2021 •
edited
Loading

Summary

Related meta issue: #107082

Replaces deprecated EuiCodeEditor in Transforms:

  • public/app/sections/create_components/advanced_pivot_editor/advanced_pivot_editor.tsx
  • public/app/sections/create_components/advanced_runtime_mappings_editor/advanced_runtime_mappings_editor.tsx
  • public/app/sections/create_components/advanced_source_editor/advanced_source_editor.tsx
  • public/app/sections/create_components/aggregation_list/popover_form.tsx
  • public/app/sections/create_components/group_by_list/popover_form.tsx
  • public/app/sections/create_components/step_define/common/filter_agg/components/editor_form.tsx
  • public/app/sections/transform_management/components/transform_list/expanded_row_json_pane.tsx

Checklist

Delete any items that are not applicable to this PR.

Fixes #41832

@alvarezmelissa87 alvarezmelissa87 added :ml release_note:skip Skip the PR/issue when compiling release notes Feature:Transforms ML transforms v7.15.0 labels Aug 12, 2021
@alvarezmelissa87 alvarezmelissa87 self-assigned this Aug 12, 2021
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner August 12, 2021 00:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Aug 12, 2021
Closed
12 tasks
@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-transform-replace-code-editor branch from bdf539b to 8df0a85 Compare August 12, 2021 17:57
peteharverson
peteharverson reviewed Aug 13, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and just left a couple of comments.

...ublic/app/sections/transform_management/components/transform_list/expanded_row_json_pane.tsx Outdated
@@ -25,13 +19,9 @@ export const ExpandedRowJsonPane: FC<Props> = ({ json }) => {
<EuiFlexGroup>
<EuiFlexItem>
<EuiSpacer size="s" />
<EuiCodeEditor
<EuiCodeBlock fontSize="s" language="json" paddingSize="s" style={{ width: '100%' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add an aria-label, something like JSON of transform configuration

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 80c039b

...ublic/app/sections/transform_management/components/transform_list/expanded_row_json_pane.tsx Outdated
@@ -25,13 +19,9 @@ export const ExpandedRowJsonPane: FC<Props> = ({ json }) => {
<EuiFlexGroup>
<EuiFlexItem>
<EuiSpacer size="s" />
<EuiCodeEditor
<EuiCodeBlock fontSize="s" language="json" paddingSize="s" style={{ width: '100%' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this doesn't have isCopyable set? It is set for the DFA one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 80c039b

@qn895
Copy link
Member

qn895 commented Aug 16, 2021

Tested the runtime field editor, query/source editor, and pivot agg editor and functionally they all work great. Left a few comments but otherwise LGTM 🎉

@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-transform-replace-code-editor branch from 91e9df1 to a30a25b Compare August 16, 2021 18:09
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
transform 917.2KB 917.9KB +700.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@alvarezmelissa87
Copy link
Contributor Author

This has been updated and is ready for a final look when you get a chance 🙏 cc @walterra, @qn895

@qn895
Copy link
Member

qn895 commented Aug 17, 2021

Latest changes LGTM 🎉

walterra
walterra approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarezmelissa87 alvarezmelissa87 merged commit 4e0375f into elastic:master Aug 18, 2021
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Aug 18, 2021
Merged
alvarezmelissa87 added a commit that referenced this pull request Aug 18, 2021
@alvarezmelissa87
[ML] Transforms: replace deprecated EuiCodeEditor (#108310) (#109028)
c4ad31e 
* replace deprecated EuiCodeEditor in transform

* update jest snapshot

* add aria label and move data attribute to parent element for testing

* update jest snapshot for aria label

* update functional tests
@alvarezmelissa87 alvarezmelissa87 deleted the ml-transform-replace-code-editor branch August 18, 2021 14:22
@peteharverson peteharverson mentioned this pull request Oct 12, 2021
Open
42 tasks
@jgowdyelastic jgowdyelastic mentioned this pull request Dec 22, 2022
Merged
jgowdyelastic added a commit that referenced this pull request Jan 9, 2023
@jgowdyelastic
[ML] Transforms: Fix transforms JSON display (#147996)
ba06f68 
Fixing a typo in the code from when the JSON editor was
[converted](#108310) from using
`EuiCodeEditor`

**Before**

![image](https://user-images.githubusercontent.com/22172091/209140230-fcb3fff5-0040-487a-bffc-581a8fe2f4e4.png)

**After**

![image](https://user-images.githubusercontent.com/22172091/209140326-98eecef0-d9bf-4145-8342-788b4166b28d.png)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 9, 2023
@jgowdyelastic
[ML] Transforms: Fix transforms JSON display (elastic#147996)
b4cfa06 
Fixing a typo in the code from when the JSON editor was
[converted](elastic#108310) from using
`EuiCodeEditor`

**Before**

![image](https://user-images.githubusercontent.com/22172091/209140230-fcb3fff5-0040-487a-bffc-581a8fe2f4e4.png)

**After**

![image](https://user-images.githubusercontent.com/22172091/209140326-98eecef0-d9bf-4145-8342-788b4166b28d.png)

(cherry picked from commit ba06f68)
kibanamachine added a commit that referenced this pull request Jan 9, 2023
@kibanamachine @jgowdyelastic
[8.6] [ML] Transforms: Fix transforms JSON display (#147996) (#148551)
835eeb4 
# Backport

This will backport the following commits from `main` to `8.6`:
- [[ML] Transforms: Fix transforms JSON display
(#147996)](#147996)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-01-09T14:58:56Z","message":"[ML]
Transforms: Fix transforms JSON display (#147996)\n\nFixing a typo in
the code from when the JSON editor
was\r\n[converted](#108310) from
using\r\n`EuiCodeEditor`\r\n\r\n**Before**\r\n\r\n![image](https://user-images.githubusercontent.com/22172091/209140230-fcb3fff5-0040-487a-bffc-581a8fe2f4e4.png)\r\n\r\n**After**\r\n\r\n![image](https://user-images.githubusercontent.com/22172091/209140326-98eecef0-d9bf-4145-8342-788b4166b28d.png)","sha":"ba06f687522fed393036ff01d9230f341e37d710","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix",":ml","Feature:Transforms","v8.6.0","v8.7.0"],"number":147996,"url":"https://github.com/elastic/kibana/pull/147996","mergeCommit":{"message":"[ML]
Transforms: Fix transforms JSON display (#147996)\n\nFixing a typo in
the code from when the JSON editor
was\r\n[converted](#108310) from
using\r\n`EuiCodeEditor`\r\n\r\n**Before**\r\n\r\n![image](https://user-images.githubusercontent.com/22172091/209140230-fcb3fff5-0040-487a-bffc-581a8fe2f4e4.png)\r\n\r\n**After**\r\n\r\n![image](https://user-images.githubusercontent.com/22172091/209140326-98eecef0-d9bf-4145-8342-788b4166b28d.png)","sha":"ba06f687522fed393036ff01d9230f341e37d710"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/147996","number":147996,"mergeCommit":{"message":"[ML]
Transforms: Fix transforms JSON display (#147996)\n\nFixing a typo in
the code from when the JSON editor
was\r\n[converted](#108310) from
using\r\n`EuiCodeEditor`\r\n\r\n**Before**\r\n\r\n![image](https://user-images.githubusercontent.com/22172091/209140230-fcb3fff5-0040-487a-bffc-581a8fe2f4e4.png)\r\n\r\n**After**\r\n\r\n![image](https://user-images.githubusercontent.com/22172091/209140326-98eecef0-d9bf-4145-8342-788b4166b28d.png)","sha":"ba06f687522fed393036ff01d9230f341e37d710"}}]}]
BACKPORT-->

Co-authored-by: James Gowdy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson left review comments

@qn895 qn895 qn895 approved these changes

@walterra walterra walterra approved these changes

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
Feature:Transforms ML transforms :ml release_note:skip Skip the PR/issue when compiling release notes v7.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Data frame transform JSON tab wrongly implies it is edit-able
6 participants
@alvarezmelissa87 @elasticmachine @qn895 @kibanamachine @walterra @peteharverson