[UnifiedFieldList] Migrate field filters and field search from Lens #147255

jughosta · 2022-12-08T14:27:07Z

Closes #145089 and #147003

Summary

This PR migrates field filters and field search from Lens plugin to UnifiedFieldList plugin:

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

…fiedFieldList

…d-filters

… types

elasticmachine · 2022-12-16T19:59:05Z

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

andreadelrio

Sass changes LGTM.

stratoula · 2022-12-19T10:56:31Z

@jughosta why can't I see the filters in Discover text based mode?

stratoula · 2022-12-19T10:58:42Z

Also another thing I see
Why the agg field doesn't have an icon in Discover?

jughosta · 2022-12-19T11:58:19Z

Hi @stratoula,
This PR is only extracting code from Lens to Unified Field List. In a follow up PR I will integrate it into Discover and address the mentioned differences. Thanks for your comments! 🙌

stratoula

Got it Julia! Visualizations team changes LGTM!

kertal

Code LGTM, great refactoring, tests, and documentation. What a nice 🎁 for 🎄! Tested locally in Chrome, Firefox, Safari. Works as expected ✅

It might be worth adding information, that you can now search by text and keyword fields in Lens (Before it was "Text string")
And we might consider to handle _index as a keyword field?

Unrelated to this PR, since it was already there, but does it make sense to filter by "Records"

src/plugins/unified_field_list/README.md

kertal · 2022-12-20T07:43:47Z

src/plugins/unified_field_list/public/components/field_icon/field_icon.tsx

+
+function normalizeFieldType(type: string) {
+  if (type === 'histogram') {
+    // TODO: check why are we replacing this type


I assume because it's an array of numbers?

https://www.elastic.co/guide/en/elasticsearch/reference/current/histogram.html

A field to store pre-aggregated numerical data representing a histogram. This data is defined using two paired arrays:

A values array of double numbers, representing the buckets for the histogram. These values must be provided in ascending order.

A corresponding counts array of integer numbers, representing how many values fall into each bucket. These numbers must be positive or zero.

kertal · 2022-12-20T08:30:00Z

x-pack/plugins/lens/public/data_views_service/loader.ts

@@ -47,7 +47,7 @@ export function convertDataViewIntoLensIndexPattern(
        customLabel: field.customLabel,
        runtimeField: field.runtimeField,
        runtime: Boolean(field.runtimeField),
-        timeSeriesMetricType: field.timeSeriesMetric,
+        timeSeriesMetric: field.timeSeriesMetric,


👍 for eye for details and consistency ... just saying!

Co-authored-by: Matthias Wilhelm <[email protected]>

kibana-ci · 2022-12-20T11:33:56Z

💚 Build Succeeded

Buildkite Build
Commit: 884d95c

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`lens`	890	887	-3
`unifiedFieldList`	51	83	+32
total			+29

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`unifiedFieldList`	203	244	+41

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	418.4KB	418.3KB	-45.0B
`lens`	1.3MB	1.3MB	-8.1KB
`unifiedFieldList`	38.1KB	48.4KB	+10.4KB
total			+2.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`lens`	30.5KB	30.5KB	-1.0B
`unifiedFieldList`	23.7KB	36.2KB	+12.4KB
total			+12.4KB

Unknown metric groups

API count

id	before	after	diff
`unifiedFieldList`	215	269	+54

async chunk count

id	before	after	diff
`unifiedFieldList`	5	7	+2

ESLint disabled in files

id	before	after	diff
`osquery`	1	2	+1

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`fleet`	61	67	+6
`osquery`	109	115	+6
`securitySolution`	439	445	+6
`unifiedFieldList`	15	17	+2
total			+22

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`fleet`	70	76	+6
`osquery`	110	117	+7
`securitySolution`	516	522	+6
`unifiedFieldList`	15	17	+2
total			+23

History

💚 Build #95663 succeeded c5134be
💚 Build #95597 succeeded d5ca525
💚 Build #95485 succeeded 5a325eb
💔 Build #95472 failed d902971
💚 Build #95444 succeeded 4327b66
💚 Build #95397 succeeded e242486

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

A follow up for #147255 Copy is suggested by Gail. <img width="614" alt="Screenshot 2023-01-16 at 12 52 23" src="https://user-images.githubusercontent.com/1415710/212672146-ca3649d5-cb0d-42d3-b666-57ce51e09f29.png"> Co-authored-by: Kaarina Tungseth <[email protected]>

Closes #145081 Part 1 of this integration was done in #147255 <img width="640" alt="Screenshot 2023-01-16 at 16 58 59" src="https://user-images.githubusercontent.com/1415710/212720438-8f37eb69-635a-4611-89bb-34b095d79b8c.png"> ## Summary This PR integrates the unified field list filters and search into Discover. - [x] Integrate into Discover - [x] Clean up deprecated code ("searchable"/"aggregatable" filters were removed too) - [x] Refactor field icons, labels, desc to use the unified ones - [x] Field list in SQL view needs refactoring to use the received field types rather than data view field types - [x] Update tests ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Stratoula Kalafateli <[email protected]>

…c#148547) Closes elastic#145081 Part 1 of this integration was done in elastic#147255 <img width="640" alt="Screenshot 2023-01-16 at 16 58 59" src="https://user-images.githubusercontent.com/1415710/212720438-8f37eb69-635a-4611-89bb-34b095d79b8c.png"> ## Summary This PR integrates the unified field list filters and search into Discover. - [x] Integrate into Discover - [x] Clean up deprecated code ("searchable"/"aggregatable" filters were removed too) - [x] Refactor field icons, labels, desc to use the unified ones - [x] Field list in SQL view needs refactoring to use the received field types rather than data view field types - [x] Update tests ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Stratoula Kalafateli <[email protected]>

jughosta added 2 commits December 8, 2022 13:59

[UnifiedFieldList] Migrate fields search and filters from Lens to Uni…

98d9224

…fiedFieldList

[UnifiedFieldList] Refactor for SQL mode too

50c3809

jughosta added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.7.0 labels Dec 8, 2022

jughosta self-assigned this Dec 8, 2022

jughosta added 23 commits December 8, 2022 16:37

[UnifiedFieldList] Create a hook for filtering logic

62902a7

Merge remote-tracking branch 'upstream/main' into 145089-migrate-fiel…

4086433

…d-filters

[UnifiedFieldList] Small fix

462074a

[UnifiedFieldList] Unify timeSeriesMetric logic

224e139

[UnifiedFieldList] Clean up labels

613c28f

[UnifiedFieldList] Refactor FieldIcon code

891af5f

[UnifiedFieldList] More refactoring for FieldIcon code

0fd2b46

[UnifiedFieldList] Refactor field filters

5580a43

[UnifiedFieldList] Optimize field filters and allow to filter SQL fields

bbe7060

[UnifiedFieldList] Clean up locals

5205356

[UnifiedFieldList] Extend with more types

146646e

[UnifiedFieldList] Skip unsupported fields when calculating available…

0f1df28

… types

[UnifiedFieldList] Render counts

5bfb237

[UnifiedFieldList] Add docLinks. Revert Discover changes.

59fc458

[UnifiedFieldList] Update styles and data-test-subj

8992c60

[UnifiedFieldList] Revert some locale changes

61813d5

[UnifiedFieldList] Update tests

89d317b

[UnifiedFieldList] Some updates

d6bf276

[UnifiedFieldList] Refactor how hooks communicate

0d8d718

[UnifiedFieldList] Add tests

a2e1aaa

[UnifiedFieldList] Add a top level FieldList component

52d5a05

[UnifiedFieldList] Simplify description id configuration

35e825d

[UnifiedFieldList] Add tests

e242486

jughosta changed the title ~~[UnifiedFieldList] Migrate field filters and field search~~ [UnifiedFieldList] Migrate field filters and field search from Lens Dec 16, 2022

[UnifiedFieldList] Fix tests

5a325eb

jughosta marked this pull request as ready for review December 16, 2022 19:59

jughosta requested review from a team as code owners December 16, 2022 19:59

Merge branch 'main' into 145089-migrate-field-filters

14a3e7d

andreadelrio approved these changes Dec 16, 2022

View reviewed changes

Merge branch 'main' into 145089-migrate-field-filters

d5ca525

stratoula approved these changes Dec 19, 2022

View reviewed changes

Merge branch 'main' into 145089-migrate-field-filters

c5134be

kertal reviewed Dec 20, 2022

View reviewed changes

kertal self-requested a review December 20, 2022 09:03

kertal approved these changes Dec 20, 2022

View reviewed changes

jughosta and others added 3 commits December 20, 2022 11:21

Merge branch 'main' into 145089-migrate-field-filters

c5bb461

Update src/plugins/unified_field_list/README.md

6424ee6

Co-authored-by: Matthias Wilhelm <[email protected]>

[UnifiedFieldList] Remove the question

884d95c

jughosta added the Feature:UnifiedFieldList The unified field list component used by Lens & Discover label Dec 20, 2022

jughosta merged commit 5535dd1 into elastic:main Dec 20, 2022

This was referenced Jan 5, 2023

[UnifiedFieldList] Update field type descriptions #148453

Merged

[Discover] Integrate unified field list filters into Discover #148547

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[UnifiedFieldList] Migrate field filters and field search from Lens #147255

[UnifiedFieldList] Migrate field filters and field search from Lens #147255

jughosta commented Dec 8, 2022 •

edited

Loading

elasticmachine commented Dec 16, 2022

andreadelrio left a comment

stratoula commented Dec 19, 2022

stratoula commented Dec 19, 2022

jughosta commented Dec 19, 2022

stratoula left a comment

kertal left a comment

kertal Dec 20, 2022

kertal Dec 20, 2022

kibana-ci commented Dec 20, 2022

API count

async chunk count

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

[UnifiedFieldList] Migrate field filters and field search from Lens #147255

[UnifiedFieldList] Migrate field filters and field search from Lens #147255

Conversation

jughosta commented Dec 8, 2022 • edited Loading

Summary

Checklist

elasticmachine commented Dec 16, 2022

andreadelrio left a comment

Choose a reason for hiding this comment

stratoula commented Dec 19, 2022

stratoula commented Dec 19, 2022

jughosta commented Dec 19, 2022

stratoula left a comment

Choose a reason for hiding this comment

kertal left a comment

Choose a reason for hiding this comment

kertal Dec 20, 2022

Choose a reason for hiding this comment

kertal Dec 20, 2022

Choose a reason for hiding this comment

kibana-ci commented Dec 20, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

async chunk count

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

History

jughosta commented Dec 8, 2022 •

edited

Loading