Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified Fieldlist] Implement and extend filter functionality in Discover #145081

Closed
Tracked by #137779
kertal opened this issue Nov 14, 2022 · 0 comments · Fixed by #148547
Closed
Tracked by #137779

[Unified Fieldlist] Implement and extend filter functionality in Discover #145081

kertal opened this issue Nov 14, 2022 · 0 comments · Fixed by #148547
Assignees
@jughosta
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Feature:UnifiedFieldList The unified field list component used by Lens & Discover impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Nov 14, 2022

Lens and Discover currently are using 2 different ways of filtering the field list. This should be unified into a single one. This change will also contain the field description popover, which is currently only available in Discover.

Currently Discover Vs Lens

Image
Image

To be implemented

There should be a single filter component, also containing the descriptions of the field types in tooltips. The way it is displayed and works in Lens should be kept, with the addition of field descriptions in for the field types. For the needs of Discover "Aggregatable" & "Searchable" should be added as filters.
@kertal kertal added loe:large Large Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Nov 14, 2022
@kertal kertal changed the title [Unified Fieldlist] Filter functionality [Unified Fieldlist] Implement and extend filter functionality in Discover Nov 14, 2022
@kertal kertal mentioned this issue Nov 18, 2022
Closed
31 tasks
@jughosta jughosta mentioned this issue Jan 9, 2023
Merged
9 tasks
jughosta added a commit that referenced this issue Jan 26, 2023
@jughosta @kibanamachine @stratoula
[Discover] Integrate unified field list filters into Discover (#148547)
c19ef2f 
Closes #145081
Part 1 of this integration was done in
#147255

<img width="640" alt="Screenshot 2023-01-16 at 16 58 59"
src="https://user-images.githubusercontent.com/1415710/212720438-8f37eb69-635a-4611-89bb-34b095d79b8c.png">


## Summary

This PR integrates the unified field list filters and search into
Discover.
- [x] Integrate into Discover
- [x] Clean up deprecated code ("searchable"/"aggregatable" filters were
removed too)
- [x] Refactor field icons, labels, desc to use the unified ones
- [x] Field list in SQL view needs refactoring to use the received field
types rather than data view field types
- [x] Update tests

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this issue Feb 6, 2023
@jughosta @kibanamachine
@stratoula @kqualters-elastic
[Discover] Integrate unified field list filters into Discover (elasti…
f7a7663 
…c#148547)

Closes elastic#145081
Part 1 of this integration was done in
elastic#147255

<img width="640" alt="Screenshot 2023-01-16 at 16 58 59"
src="https://user-images.githubusercontent.com/1415710/212720438-8f37eb69-635a-4611-89bb-34b095d79b8c.png">


## Summary

This PR integrates the unified field list filters and search into
Discover.
- [x] Integrate into Discover
- [x] Clean up deprecated code ("searchable"/"aggregatable" filters were
removed too)
- [x] Refactor field icons, labels, desc to use the unified ones
- [x] Field list in SQL view needs refactoring to use the received field
types rather than data view field types
- [x] Update tests

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Feature:UnifiedFieldList The unified field list component used by Lens & Discover impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Integrate unified field list filters into Discover jughosta/kibana
2 participants
@kertal @jughosta