Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code owner for kbn-monaco package #146967

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Update code owner for kbn-monaco package #146967

merged 3 commits into from
Dec 5, 2022

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Dec 5, 2022 •
edited
Loading

Summary

Replace @elastic/kibana-app-services -> @elastic/kibana-global-experience for kbn-monaco package

While working on #146379 I just saw that the plugin has the wrong code-owner. Let's fix it

@alexwizp alexwizp marked this pull request as ready for review December 5, 2022 09:27
@alexwizp alexwizp requested a review from a team as a code owner December 5, 2022 09:27
@alexwizp alexwizp self-assigned this Dec 5, 2022
@alexwizp alexwizp added v8.7.0 Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) release_note:skip Skip the PR/issue when compiling release notes labels Dec 5, 2022
@alexwizp
Copy link
Contributor Author

alexwizp commented Dec 5, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@alexwizp alexwizp merged commit 4735ad8 into elastic:main Dec 5, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

Assignees

@alexwizp alexwizp

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexwizp @kibana-ci @Dosant @kibanamachine