-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Step 1][ESQL] Syntax part #146379
[Step 1][ESQL] Syntax part #146379
Conversation
07b84e1
to
49e9a93
Compare
7e55db2
to
a37ef16
Compare
@elasticmachine merge upstream |
-2MB ??? 😍 |
@@ -39,7 +39,7 @@ snapshots.js | |||
/packages/kbn-test/src/functional_test_runner/lib/config/__tests__/fixtures/ | |||
/packages/kbn-ui-framework/dist | |||
/packages/kbn-flot-charts/lib | |||
/packages/kbn-monaco/src/painless/antlr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be the source of the 2MB
drop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, please review https://github.com/elastic/kibana/pull/146379/files#diff-37720dcf8abc68d5211a94d91df2c70969073de66f75f1a2bcd7fa8a54c9f8bb . I've moved all workers into separate chunks. It's a reason
packages/kbn-monaco/src/esql/lib/monaco/esql_tokens_provider.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Marco Liberati <[email protected]>
…-ref HEAD~1..HEAD --fix'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visualizations team changes LGTM
## Summary Replace @elastic/kibana-app-services -> @elastic/kibana-global-experience for `kbn-monaco` package While working on #146379 I just saw that the plugin has the wrong code-owner. Let's fix it Co-authored-by: Kibana Machine <[email protected]>
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @alexwizp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR unfortunately currently breaks Canvas. To reproduce.
- Go to canvas
- Add an element like a Data Table (not an embeddable)
- Click on the element and move to the data tab
- Click Elasticsearch Sql.
Canvas shows a blank screen, and the console shows these errors:
Likely the editor for the data source needs to be re-instated.
We should create functional tests which cover this use case so this doesn't happen again. I have opened an issue to track our functional test additions.
@ThomThomson could you please try again with bootstrapping kibana. It's important cause Screen: Screen.Recording.2022-12-06.at.11.48.09.mov |
@ThomThomson I can't reproduce it either, I think that Aliaksei is right and you should bootstrap first! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the noise folks, re-reviewed today (properly bootstrapped), and the ESql section of Canvas works as expected! LGTM!
@elastic/kibana-global-experience please have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM.
Part of: #144296
Summary
First step of
[ESQL] Improve the typing experience
(#144296). This PR is the skeleton for later parts, but already supports basic parsing scenarios.What was done:
ESQL
language in@kbn/monaco
package. Parsing was done using theantl
syntax;kbnUiSharedDeps
-srcJs bundle has been optimised, all workers have been moved into separate chunks. This gave almost minus2 MB
🕺esql
lang was renamed tosql
. In order not to confuse anyone in the futurepainless
folder was moved tocommon
and reused in ESQL (probably needs some refactoring in future)Next steps:
ANLT
syntax to cover all casesAutocomplete
featureHow to use new
ESQL Lang
:To use new language 2 properties should be set for
CodeEditor
componentCurrently syntax highlighting looks like:
Will be updated in Step 2