[6.x] [11532] Improve local nav accessibility (#14365) #14554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use h2 elements for titles in Sharing dropdown. * Override inherited typographic styles in kuiLocalDropdownTitle. * Use h2 elements for titles in Console dropdowns. * Update kuiLocalDropdownHeader__label class to be applicable to legend elements. * Update Console settings menu with aria labeling and UI Framework styles. * Remove unused config-close styles. * Update Dashboard local nav dropdowns with form labels and h2 elements. * Add support for dark theme to kuiCheckBox. * Update Dashboard local nav dropdowns and saved-object-save-as-check-box directive with kuiCheckBoxLabel styles. * Update Discover local nav with h2 elements. * Update Visualize local nav with h2 element. * Add aria-label to unlabeled inputs in Discover, Visualuze, and Timelion inputs. * Update Timelion local nav with h2 elements. * Update timepicker with tab roles, h2 elements, and UI Framework styles. * Improve labeling and add aria-selected to timepicker tabs. - Refactor timepicker tabs to adhere to tablist structure correctly. * Add tablist role.
cjcenizal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports pull request #14365 to 6.x