[11532] Improve local nav accessibility #14365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
changed the title
cjcenizal
added
Project:Accessibility
bug
timroes
suggested changes
Oct 11, 2017
| type="number" | ||
| required | ||
| class="kuiLocalDropdownInput kuiVerticalRhythmSmall" | ||
| aria-describedby="consoleFontSize" |
There was a problem hiding this comment.
I think we should rather use aria-labelledby here, so that "Font Size" will really become the accessible name of that input field.
| > | ||
| <li | ||
| role="tab" | ||
| ng-class="{active: mode === 'quick' }" |
There was a problem hiding this comment.
Could you add aria-selected="{{ mode === 'quick' }}" to this.
|
|
||
| <li | ||
| role="tab" | ||
| ng-class="{active: mode === 'relative' }" |
There was a problem hiding this comment.
Could you also add aria-selected here.
|
|
||
| <li | ||
| role="tab" | ||
| ng-class="{active: mode === 'absolute' }" |
There was a problem hiding this comment.
Could you also add aria-selected here.
|
Thanks for the review @timroes! I've addressed your feedback. Could you take another look? |
|
jenkins test this |
timroes
approved these changes
Oct 11, 2017
cjcenizal
force-pushed
the
11532/local-nav-general-accessibility
branch
from
d936111 to
3b20fcf
Compare
|
jenkins, test this |
|
You need to merge master into this, to fix the licencing issues. |
cjcenizal
force-pushed
the
11532/local-nav-general-accessibility
branch
2 times, most recently
from
dd727bb to
d0c42b1
Compare
cjcenizal
force-pushed
the
11532/local-nav-general-accessibility
branch
from
d0c42b1 to
bb89ee6
Compare
|
jenkins, test this |
…ox directive with kuiCheckBoxLabel styles.
- Refactor timepicker tabs to adhere to tablist structure correctly.
cjcenizal
force-pushed
the
11532/local-nav-general-accessibility
branch
from
bb89ee6 to
b573dde
Compare
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Oct 24, 2017
* Use h2 elements for titles in Sharing dropdown. * Override inherited typographic styles in kuiLocalDropdownTitle. * Use h2 elements for titles in Console dropdowns. * Update kuiLocalDropdownHeader__label class to be applicable to legend elements. * Update Console settings menu with aria labeling and UI Framework styles. * Remove unused config-close styles. * Update Dashboard local nav dropdowns with form labels and h2 elements. * Add support for dark theme to kuiCheckBox. * Update Dashboard local nav dropdowns and saved-object-save-as-check-box directive with kuiCheckBoxLabel styles. * Update Discover local nav with h2 elements. * Update Visualize local nav with h2 element. * Add aria-label to unlabeled inputs in Discover, Visualuze, and Timelion inputs. * Update Timelion local nav with h2 elements. * Update timepicker with tab roles, h2 elements, and UI Framework styles. * Improve labeling and add aria-selected to timepicker tabs. - Refactor timepicker tabs to adhere to tablist structure correctly. * Add tablist role.
cjcenizal
added a commit
that referenced
this pull request
Oct 25, 2017
* Use h2 elements for titles in Sharing dropdown. * Override inherited typographic styles in kuiLocalDropdownTitle. * Use h2 elements for titles in Console dropdowns. * Update kuiLocalDropdownHeader__label class to be applicable to legend elements. * Update Console settings menu with aria labeling and UI Framework styles. * Remove unused config-close styles. * Update Dashboard local nav dropdowns with form labels and h2 elements. * Add support for dark theme to kuiCheckBox. * Update Dashboard local nav dropdowns and saved-object-save-as-check-box directive with kuiCheckBoxLabel styles. * Update Discover local nav with h2 elements. * Update Visualize local nav with h2 element. * Add aria-label to unlabeled inputs in Discover, Visualuze, and Timelion inputs. * Update Timelion local nav with h2 elements. * Update timepicker with tab roles, h2 elements, and UI Framework styles. * Improve labeling and add aria-selected to timepicker tabs. - Refactor timepicker tabs to adhere to tablist structure correctly. * Add tablist role.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11532
Replaces #14363