[Expressions] Add a flag to opt-out of the partial results in the expressions

[dokmic]

Summary

Resolves #143344.

Checklist

• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

[Dosant]

Resolves #143444.

Is this is the right issue? Doesn't look like it

[Dosant]

Trying to understand:
Previously we had partial switch inside the expression loader. Looks like it was false by default and that's why we didn't show partial results in charts.

Now we also add the switch to the execution: why? what is the benefit? How this flag related to the one in the expression loader? Why it is by default true for the execution, but false for the loader ?

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: a61e0c8

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
expressions	98.1KB	98.1KB	+88.0B

Unknown metric groups

API count

id	before	after	diff
expressions	2191	2193	+2

ESLint disabled in files

id	before	after	diff
osquery	1	2	+1

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	19	21	+2
fleet	58	64	+6
osquery	106	111	+5
securitySolution	440	446	+6
total			+19

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	20	22	+2
fleet	66	72	+6
osquery	107	113	+6
securitySolution	517	523	+6
total			+20

History

• 💔 Build #84846 failed b8412b21713b572172bd2add21e2b57c2f6c558c
• 💚 Build #84175 succeeded 9503ab74acdd867c7460437b0c56587a50fecc15
• 💔 Build #83994 failed c6a6082c65664911edd923293e80206faa4bf02a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[dokmic]

@Dosant Thanks for this finding. That makes total sense.

I've reused the newly added flag in the loader and changed the default value to false. Considering #141673 and #143344, it makes sense to disable partial results to avoid potential performance issues and side effects since we are not using them yet. My only concern is that we had it turned on for a while, and now it's changed. WDYT?

Additionally, I've moved the throttle parameter to the execution context to align with the partial flag.

[flash1293]

@Dosant could you take another look at this? We depend on it for the metric trendlines

[Dosant]

My only concern is that we had it turned on for a while, and now it's changed. WDYT?

In my opinion, If no one actually uses them, there is no harm in disabling them on the expression layer by default as this adds overhead.
And if someone needs it, then can enable it by using the flag, right?

I'll run and play with it shortly

[flash1293]

+1 for disabling by default.

[Dosant]

LGTM 👍

[drewdaemon]

So, I guess this means that we won't have to do anything on the Lens side to take advantage of this change.