[Maps] Remove deprecated usage of indexPattern.title

[nickpeihl]

Summary

Fixes deprecated data view calls.

Accessing indexPattern.title directly has been deprecated and should be replaced by the getIndexPattern method. In many cases I changed the local variable to dataView because calling indexPattern.getIndexPattern() may be confusing.

We could do much more with replacing indexPattern with dataView in other parts of the code, but I kept this PR small so that we only need to fix the deprecations.

[elasticmachine]

Pinging @elastic/kibana-gis (Team:Geo)

[nickpeihl]

@elasticmachine merge upstream

[jsanz]

Code changes looks good to me, thanks for taking care of the deprecation. I've checked locally for any other usage of .title for index patterns or data views but looks like everything is addressed 👍

[nreese]

LGTM - thanks for cleaning up deprecated use of dataView.title and +1 on renames.
code review

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: f9a5b98

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
maps	2.7MB	2.7MB	-39.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
maps	82.1KB	82.1KB	+8.0B

Unknown metric groups

References to deprecated APIs

id	before	after	diff
maps	77	21	-56

History

• 💚 Build #80834 succeeded 5cf7bb4
• 💔 Build #80735 failed f6ace66

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream