-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] use point-in-time for paging search results #144201
Merged
tsullivan
merged 15 commits into
elastic:main
from
tsullivan:reporting/searchsource-exporttype
Nov 7, 2022
Merged
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
adaae66
[Reporting] use point-in-time for paging search results
tsullivan dcccbb5
add new PIT tests to data plugin
tsullivan a46385e
Merge branch 'main' into reporting/searchsource-exporttype
tsullivan 42c15b6
Merge branch 'main' into reporting/searchsource-exporttype
tsullivan fec0f95
fix deprecation
tsullivan 6284ac2
update point-in-time ID to the latest one received
tsullivan 73a428e
add warning for shard failure
tsullivan 6dfecf8
fix/cleanup csv generation test
tsullivan 1ada507
add requestTimeout to openPit request
tsullivan c5710b1
logging polishes
tsullivan 740a2c7
Merge remote-tracking branch 'elastic/main' into reporting/searchsour…
tsullivan 1905042
fix test
tsullivan de821a8
Merge branch 'main' into reporting/searchsource-exporttype
jloleysens 92ce96f
remove confusing comment
tsullivan b03f445
Merge remote-tracking branch 'elastic/main' into reporting/searchsour…
tsullivan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...server/export_types/csv_searchsource/generate_csv/__snapshots__/generate_csv.test.ts.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be enforced in
search source
, before setting the pit.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we chatted a bit to clarify this, and agreed it's better to just get rid of this comment.