-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] use point-in-time for paging search results #144201
[Reporting] use point-in-time for paging search results #144201
Conversation
316043b
to
31822a2
Compare
6317085
to
31608ff
Compare
538cfee
to
d90e0c4
Compare
d90e0c4
to
dcccbb5
Compare
searchAfter?: estypes.SortResults; | ||
/** | ||
* Allow querying to use a point-in-time ID for paging results | ||
* Requires searchAfter when the page index is > 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be enforced in search source
, before setting the pit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we chatted a bit to clarify this, and agreed it's better to just get rid of this comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @tsullivan ! I'm glad to see we can employ the recommended way of deeply paging through data for CSV exports 👏🏻
Tesed locally on a small-ish sample - do you have any data on how this performs in Kibana with larger datasets?
💚 Build Succeeded
Metrics [docs]Page load bundle
Unknown metric groupsAPI count
ESLint disabled in files
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Summary
Closes #143144
Based on de10eae
Checklist
Reviewer guide
See documentation on paging search results:
Release Note
Fixed a bug with CSV export in Discover, where searching over hundreds of shards would result in an incomplete CSV file.