Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Endpoint] Adds RBAC API checks for event filters #144009

Merged
merged 2 commits into from
Oct 27, 2022
Merged

[Security Solution][Endpoint] Adds RBAC API checks for event filters #144009

merged 2 commits into from
Oct 27, 2022

Conversation

dasansol92
Copy link
Contributor

Summary

For maintainers

@dasansol92 dasansol92 added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.6.0 labels Oct 26, 2022
@dasansol92 dasansol92 marked this pull request as ready for review October 26, 2022 12:58
@dasansol92 dasansol92 requested a review from a team as a code owner October 26, 2022 12:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

joeypoon
joeypoon approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@joeypoon joeypoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙆‍♂️

@dasansol92 dasansol92 changed the title Adds RBAC API checks for event filters [Security Solution][Endpoint] Adds RBAC API checks for event filters Oct 26, 2022
@dasansol92
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gergoabraham
gergoabraham approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

I've tested it, and was able to check it with reading the event filter list, receiving 403 when privilege is taken.
image

gergoabraham
gergoabraham requested changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked it with creating a new filter, and was able with read permission - please don't merge yet, I need to double check

gergoabraham
gergoabraham approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, everything works great. 👍

@dasansol92 dasansol92 merged commit 028fa94 into elastic:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gergoabraham gergoabraham gergoabraham approved these changes

@joeypoon joeypoon joeypoon approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dasansol92 @elasticmachine @kibana-ci @joeypoon @gergoabraham @kibanamachine