Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Fix help documentation link for dashboard #143894

Merged
merged 2 commits into from
Oct 25, 2022
Merged

[Dashboard] Fix help documentation link for dashboard #143894

merged 2 commits into from
Oct 25, 2022

Conversation

Heenawter
Copy link
Contributor

@Heenawter Heenawter commented Oct 24, 2022 •
edited by kibanamachine
Loading

Summary

Seemingly random PR, incoming 🚀

A bug was introduced in the Dashboard services abstraction PR where the Dashboard help link no longer sent the user to the correct location - instead, it sent them to the generic Kibana documentation. This PR fixes this by adding the Dashboard documentation link to the documentationLinks service and setting the correct help extension in addHelpMenuToAppChrome.

Before

before.mov

After

after.mov

Checklist

For maintainers

@Heenawter Heenawter added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.6.0 v8.5.0 backport:all-open Backport to all branches that could still receive a release and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 24, 2022
@Heenawter Heenawter self-assigned this Oct 24, 2022
@Heenawter Heenawter added release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Oct 24, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 423.6KB 423.6KB +33.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Heenawter

@Heenawter Heenawter marked this pull request as ready for review October 24, 2022 21:12
@Heenawter Heenawter requested a review from a team as a code owner October 24, 2022 21:12
@kibanamachine kibanamachine added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Oct 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter Heenawter changed the title [Dashboard] Modify help link for dashboard [Dashboard] Fix help documentation link for dashboard Oct 24, 2022
nickpeihl
nickpeihl approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

code review and tested in chrome

@Heenawter Heenawter merged commit 94fe004 into elastic:main Oct 25, 2022
@kibanamachine kibanamachine mentioned this pull request Oct 25, 2022
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 7.17 Backport failed because of merge conflicts
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 143894

Questions ?

Please refer to the Backport tool documentation

@Heenawter Heenawter added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:all-open Backport to all branches that could still receive a release labels Oct 25, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 25, 2022
@Heenawter
[Dashboard] Fix help documentation link for dashboard (elastic#143894)
b517736 
* Modify help link for dashboard

* Fix stub

(cherry picked from commit 94fe004)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@Heenawter Heenawter added v8.5.1 and removed v8.5.0 labels Oct 25, 2022
kibanamachine added a commit that referenced this pull request Oct 25, 2022
@kibanamachine @Heenawter
[Dashboard] Fix help documentation link for dashboard (#143894) (#143985
f784831 
)

* Modify help link for dashboard

* Fix stub

(cherry picked from commit 94fe004)

Co-authored-by: Hannah Mudge <[email protected]>
@mistic mistic removed the v8.5.0 label Nov 1, 2022
@Heenawter Heenawter deleted the fix-dashboard-help-link_2022-10-24 branch December 30, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees

@Heenawter Heenawter

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.5.1 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Heenawter @kibana-ci @elasticmachine @kibanamachine @nickpeihl @mistic